Skip to content

Commit a0f6adb

Browse files
krisseldenRobert Jackson
authored andcommitted
[BUGFIX release] Upgrade to latest glimmer-vm
(cherry picked from commit 6d5cb2a)
1 parent 506794e commit a0f6adb

File tree

14 files changed

+132
-233
lines changed

14 files changed

+132
-233
lines changed

package.json

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -74,15 +74,15 @@
7474
},
7575
"devDependencies": {
7676
"@babel/preset-env": "^7.7.7",
77-
"@glimmer/compiler": "0.47.9",
77+
"@glimmer/compiler": "^0.48.0",
7878
"@glimmer/env": "^0.1.7",
79-
"@glimmer/interfaces": "0.47.9",
80-
"@glimmer/node": "0.47.9",
81-
"@glimmer/opcode-compiler": "0.47.9",
82-
"@glimmer/program": "0.47.9",
83-
"@glimmer/reference": "0.47.9",
84-
"@glimmer/runtime": "0.47.9",
85-
"@glimmer/validator": "0.47.9",
79+
"@glimmer/interfaces": "^0.48.0",
80+
"@glimmer/node": "^0.48.0",
81+
"@glimmer/opcode-compiler": "^0.48.0",
82+
"@glimmer/program": "^0.48.0",
83+
"@glimmer/reference": "^0.48.0",
84+
"@glimmer/runtime": "^0.48.0",
85+
"@glimmer/validator": "^0.48.0",
8686
"@simple-dom/document": "^1.4.0",
8787
"@types/qunit": "^2.5.4",
8888
"@types/rsvp": "^4.0.3",

packages/@ember/-internals/glimmer/lib/component-managers/curly.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,9 @@ import {
2121
WithJitDynamicLayout,
2222
WithJitStaticLayout,
2323
} from '@glimmer/interfaces';
24-
import { unwrapTemplate } from '@glimmer/opcode-compiler';
2524
import { RootReference, VersionedPathReference } from '@glimmer/reference';
2625
import { PrimitiveReference } from '@glimmer/runtime';
27-
import { EMPTY_ARRAY } from '@glimmer/util';
26+
import { EMPTY_ARRAY, unwrapTemplate } from '@glimmer/util';
2827
import { combine, Tag, validate, value } from '@glimmer/validator';
2928
import { SimpleElement } from '@simple-dom/interface';
3029
import { BOUNDS, DIRTY_TAG, HAS_BLOCK, IS_DISPATCHING_ATTRS } from '../component';

packages/@ember/-internals/glimmer/lib/component-managers/custom.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ import {
1515
VMArguments,
1616
WithJitStaticLayout,
1717
} from '@glimmer/interfaces';
18-
import { unwrapTemplate } from '@glimmer/opcode-compiler';
1918
import { ComponentRootReference, PathReference } from '@glimmer/reference';
19+
import { unwrapTemplate } from '@glimmer/util';
2020
import { consume, createTag, isConst, Tag } from '@glimmer/validator';
2121

2222
import { ENV } from '@ember/-internals/environment';

packages/@ember/-internals/glimmer/lib/component-managers/internal.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Factory, Owner } from '@ember/-internals/owner';
22
import { ComponentDefinition, WithJitStaticLayout } from '@glimmer/interfaces';
3-
import { unwrapTemplate } from '@glimmer/opcode-compiler';
3+
import { unwrapTemplate } from '@glimmer/util';
44
import RuntimeResolver from '../resolver';
55
import { OwnedTemplate } from '../template';
66
import AbstractComponentManager from './abstract';

packages/@ember/-internals/glimmer/lib/component-managers/outlet.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ import {
1515
WithDynamicTagName,
1616
WithJitStaticLayout,
1717
} from '@glimmer/interfaces';
18-
import { unwrapTemplate } from '@glimmer/opcode-compiler';
1918
import { ComponentRootReference, VersionedPathReference } from '@glimmer/reference';
2019
import { EMPTY_ARGS } from '@glimmer/runtime';
20+
import { unwrapTemplate } from '@glimmer/util';
2121
import { CONSTANT_TAG, createTag, Tag } from '@glimmer/validator';
2222

2323
import { SimpleElement } from '@simple-dom/interface';

packages/@ember/-internals/glimmer/lib/component-managers/root.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ import {
99
Option,
1010
VMArguments,
1111
} from '@glimmer/interfaces';
12-
import { unwrapTemplate } from '@glimmer/opcode-compiler';
1312
import { EMPTY_ARGS } from '@glimmer/runtime';
13+
import { unwrapTemplate } from '@glimmer/util';
1414
import { DIRTY_TAG } from '../component';
1515
import { EmberVMEnvironment } from '../environment';
1616
import { DynamicScope } from '../renderer';

packages/@ember/-internals/glimmer/lib/component-managers/template-only.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ import {
77
VMArguments,
88
WithJitStaticLayout,
99
} from '@glimmer/interfaces';
10-
import { unwrapTemplate } from '@glimmer/opcode-compiler';
1110
import { NULL_REFERENCE } from '@glimmer/runtime';
11+
import { unwrapTemplate } from '@glimmer/util';
1212
import { CONSTANT_TAG, createTag } from '@glimmer/validator';
1313
import { EmberVMEnvironment } from '../environment';
1414
import RuntimeResolver from '../resolver';

packages/@ember/-internals/glimmer/lib/helpers/-i.ts

Lines changed: 0 additions & 12 deletions
This file was deleted.

packages/@ember/-internals/glimmer/lib/renderer.ts

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@ import {
1515
RenderResult,
1616
SyntaxCompilationContext,
1717
} from '@glimmer/interfaces';
18-
import { JitContext, unwrapHandle, unwrapTemplate } from '@glimmer/opcode-compiler';
19-
import { RuntimeProgramImpl } from '@glimmer/program';
18+
import { JitContext } from '@glimmer/opcode-compiler';
2019
import { VersionedPathReference } from '@glimmer/reference';
2120
import {
2221
clientBuilder,
@@ -26,11 +25,12 @@ import {
2625
DOMTreeConstruction,
2726
inTransaction,
2827
IteratorResult,
29-
JitRuntimeFromProgram,
28+
JitRuntime,
3029
JitSyntaxCompilationContext,
3130
renderJitMain,
3231
UNDEFINED_REFERENCE,
3332
} from '@glimmer/runtime';
33+
import { unwrapHandle, unwrapTemplate } from '@glimmer/util';
3434
import { CURRENT_TAG, runInAutotrackingTransaction, validate, value } from '@glimmer/validator';
3535
import { SimpleDocument, SimpleElement, SimpleNode } from '@simple-dom/interface';
3636
import RSVP from 'rsvp';
@@ -282,27 +282,21 @@ export abstract class Renderer {
282282
let runtimeResolver = (this._runtimeResolver = new RuntimeResolver(env.isInteractive));
283283
let compileTimeResolver = new CompileTimeResolver(runtimeResolver);
284284

285-
this._context = JitContext(compileTimeResolver);
285+
let context = (this._context = JitContext(compileTimeResolver));
286286

287-
populateMacros(this._context.macros);
288-
289-
let program = new RuntimeProgramImpl(
290-
this._context.program.constants,
291-
this._context.program.heap
292-
);
287+
populateMacros(context.macros);
293288

294289
let runtimeEnvironmentDelegate = new EmberEnvironmentDelegate(owner, env.isInteractive);
295-
296-
this._runtime = JitRuntimeFromProgram(
290+
this._runtime = JitRuntime(
297291
{
298292
appendOperations: env.hasDOM
299293
? new DOMTreeConstruction(document)
300294
: new NodeDOMTreeConstruction(document),
301295
updateOperations: new DOMChanges(document),
302296
},
303-
program,
304-
runtimeResolver,
305-
runtimeEnvironmentDelegate
297+
runtimeEnvironmentDelegate,
298+
context,
299+
runtimeResolver
306300
);
307301
}
308302

packages/@ember/-internals/glimmer/lib/resolver.ts

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,16 @@ import { PARTIALS } from '@ember/deprecated-features';
1212
import EmberError from '@ember/error';
1313
import { _instrumentStart } from '@ember/instrumentation';
1414
import { DEBUG } from '@glimmer/env';
15-
import { ComponentDefinition, Helper, JitRuntimeResolver, Option } from '@glimmer/interfaces';
16-
import { PartialDefinition, unwrapTemplate } from '@glimmer/opcode-compiler';
15+
import {
16+
ComponentDefinition,
17+
Helper,
18+
JitRuntimeResolver,
19+
Option,
20+
PartialDefinition,
21+
} from '@glimmer/interfaces';
22+
import { PartialDefinitionImpl } from '@glimmer/opcode-compiler';
1723
import { getDynamicVar, ModifierDefinition } from '@glimmer/runtime';
24+
import { unwrapTemplate } from '@glimmer/util';
1825
import { CurlyComponentDefinition } from './component-managers/curly';
1926
import { CustomManagerDefinition, ManagerDelegate } from './component-managers/custom';
2027
import InternalComponentManager, {
@@ -23,7 +30,6 @@ import InternalComponentManager, {
2330
import { TemplateOnlyComponentDefinition } from './component-managers/template-only';
2431
import { isHelperFactory, isSimpleHelper } from './helper';
2532
import { default as componentAssertionHelper } from './helpers/-assert-implicit-component-helper-argument';
26-
import { default as parseIntHelper } from './helpers/-i';
2733
import { default as inputTypeHelper } from './helpers/-input-type';
2834
import { default as normalizeClassHelper } from './helpers/-normalize-class';
2935
import { default as trackArray } from './helpers/-track-array';
@@ -251,7 +257,6 @@ const BUILTINS_HELPERS: IBuiltInHelpers = {
251257
unless: inlineUnless,
252258
'-hash': hash,
253259
'-each-in': eachIn,
254-
'-i': parseIntHelper,
255260
'-input-type': inputTypeHelper,
256261
'-normalize-class': normalizeClassHelper,
257262
'-track-array': trackArray,
@@ -440,7 +445,7 @@ export default class RuntimeResolver implements JitRuntimeResolver<OwnedTemplate
440445
let templateFactory = lookupPartial(name, owner);
441446
let template = templateFactory(owner);
442447

443-
return new PartialDefinition(name, template);
448+
return new PartialDefinitionImpl(name, template);
444449
}
445450

446451
private _lookupModifier(name: string, meta: OwnedTemplateMeta) {

packages/@ember/-internals/glimmer/lib/utils/debug-render-tree.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
import { assert } from '@ember/debug';
22
import { Bounds, CapturedArguments, Option } from '@glimmer/interfaces';
3-
import { unwrapTemplate } from '@glimmer/opcode-compiler';
43
import { VersionedPathReference } from '@glimmer/reference';
5-
import { expect, Stack } from '@glimmer/util';
4+
import { expect, Stack, unwrapTemplate } from '@glimmer/util';
65
import { SimpleElement, SimpleNode } from '@simple-dom/interface';
76
import { OwnedTemplate } from '../template';
87

packages/ember-template-compiler/lib/plugins/index.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import AssertLocalVariableShadowingHelperInvocation from './assert-local-variabl
55
import AssertReservedNamedArguments from './assert-reserved-named-arguments';
66
import AssertSplattributeExpressions from './assert-splattribute-expression';
77
import DeprecateSendAction from './deprecate-send-action';
8-
import SafeIntegersBugfix from './safe-integers-bugfix';
98
import TransformActionSyntax from './transform-action-syntax';
109
import TransformAttrsIntoArgs from './transform-attrs-into-args';
1110
import TransformComponentInvocation from './transform-component-invocation';
@@ -42,7 +41,6 @@ const transforms: Array<APluginFunc> = [
4241
AssertSplattributeExpressions,
4342
TransformEachTrackArray,
4443
TransformWrapMountAndOutlet,
45-
SafeIntegersBugfix,
4644
];
4745

4846
if (SEND_ACTION) {

packages/ember-template-compiler/lib/plugins/safe-integers-bugfix.ts

Lines changed: 0 additions & 87 deletions
This file was deleted.

0 commit comments

Comments
 (0)