Skip to content

Commit 1fdc0e0

Browse files
authored
Make other.test_warn_no_filesystem run fully in WasmFS (#20045)
The first part of the test was fine, but later parts used hardcoded "run_process(EMCC" invocations without adding the emcc_flags, so they were not actually run in wasmfs mode.
1 parent 25c104e commit 1fdc0e0

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

test/test_other.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7656,13 +7656,13 @@ def test(contents):
76567656
test("Module['FS_createPreloadedFile']('waka waka, just warning check')")
76577657

76587658
# text is in the source when needed, but when forcing FS, it isn't there
7659-
self.run_process([EMCC, 'src.c'])
7659+
self.emcc('src.c')
76607660
self.assertContained(error, read_file('a.out.js'))
7661-
self.run_process([EMCC, 'src.c', '-sFORCE_FILESYSTEM']) # forcing FS means no need
7661+
self.emcc('src.c', args=['-sFORCE_FILESYSTEM']) # forcing FS means no need
76627662
self.assertNotContained(error, read_file('a.out.js'))
7663-
self.run_process([EMCC, 'src.c', '-sASSERTIONS=0']) # no assertions, no need
7663+
self.emcc('src.c', args=['-sASSERTIONS=0']) # no assertions, no need
76647664
self.assertNotContained(error, read_file('a.out.js'))
7665-
self.run_process([EMCC, 'src.c', '-O2']) # optimized, so no assertions
7665+
self.emcc('src.c', args=['-O2']) # optimized, so no assertions
76667666
self.assertNotContained(error, read_file('a.out.js'))
76677667

76687668
def test_warn_module_out_err(self):

0 commit comments

Comments
 (0)