Remove unnecessary dependency from deps_info.py. NFC (#19166)

sbc100 · web-flow · commit 53948389b6e1 · 2023-04-13T09:34:24.000-07:00
This was recently introduced in #16627 but when to a different deps system in #18905 I noticed it is not necessary.
diff --git a/test/other/metadce/test_metadce_cxx_ctors1.exports b/test/other/metadce/test_metadce_cxx_ctors1.exports
@@ -1,4 +1,3 @@
-__cxa_increment_exception_refcount
 __cxa_is_pointer_type
 __errno_location
 __indirect_function_table
diff --git a/test/other/metadce/test_metadce_cxx_ctors1.size b/test/other/metadce/test_metadce_cxx_ctors1.size
@@ -1 +1 @@
-123573
+123454
diff --git a/test/other/metadce/test_metadce_cxx_ctors2.exports b/test/other/metadce/test_metadce_cxx_ctors2.exports
@@ -1,4 +1,3 @@
-__cxa_increment_exception_refcount
 __cxa_is_pointer_type
 __errno_location
 __indirect_function_table
diff --git a/test/other/metadce/test_metadce_cxx_ctors2.size b/test/other/metadce/test_metadce_cxx_ctors2.size
@@ -1 +1 @@
-123478
+123359
diff --git a/test/other/metadce/test_metadce_cxx_noexcept.exports b/test/other/metadce/test_metadce_cxx_noexcept.exports
@@ -1,4 +1,3 @@
-__cxa_increment_exception_refcount
 __cxa_is_pointer_type
 __errno_location
 __indirect_function_table
diff --git a/test/other/metadce/test_metadce_cxx_noexcept.size b/test/other/metadce/test_metadce_cxx_noexcept.size
@@ -1 +1 @@
-126371
+126251
diff --git a/tools/deps_info.py b/tools/deps_info.py
@@ -186,12 +186,9 @@ def append_deps_info(js_symbol_deps):
 def get_deps_info():
   if not settings.WASM_EXCEPTIONS and settings.LINK_AS_CXX:
     _deps_info['__cxa_end_catch'] = ['setThrew', '__cxa_decrement_exception_refcount']
-    base_js_exception_deps = [
-      '__cxa_is_pointer_type',
-      '__cxa_increment_exception_refcount',
-    ]
+    base_js_exception_deps = ['__cxa_is_pointer_type']
     _deps_info['__cxa_throw'] = base_js_exception_deps
-    _deps_info['__cxa_begin_catch'] = base_js_exception_deps
+    _deps_info['__cxa_begin_catch'] = base_js_exception_deps + ['__cxa_increment_exception_refcount']
     _deps_info['__cxa_find_matching_catch'] = base_js_exception_deps + ['__cxa_can_catch', 'setTempRet0']
     for i in range(1, 10):
       _deps_info['__cxa_find_matching_catch_%d' % i] = _deps_info['__cxa_find_matching_catch']

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-__cxa_increment_exception_refcount`
`2`	`1`	`__cxa_is_pointer_type`
`3`	`2`	`__errno_location`
`4`	`3`	`__indirect_function_table`