Skip to content

Commit 574b041

Browse files
authored
Remove unnecessary testing in browser.test_pthread_gcc_atomic_fetch_and_op (#12333)
We tested heavily because of the old regex stuff in fastcomp pthreads. Still seems useful to ensure one pthreads tests has all opt levels, but remove excessive debug levels. This makes the test 2x faster.
1 parent 13eddf9 commit 574b041

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

tests/test_browser.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3613,10 +3613,8 @@ def test_pthread_main_thread_blocking(self, name):
36133613
@no_firefox('https://bugzilla.mozilla.org/show_bug.cgi?id=1666568')
36143614
@requires_threads
36153615
def test_pthread_gcc_atomic_fetch_and_op(self):
3616-
# We need to resort to using regexes to optimize out SharedArrayBuffer when pthreads are not supported, which is brittle!
3617-
# Therefore perform very extensive testing of different codegen modes to catch any problems.
36183616
for opt in [[], ['-O1'], ['-O2'], ['-O3'], ['-Os']]:
3619-
for debug in [[], ['-g1'], ['-g2'], ['-g4']]:
3617+
for debug in [[], ['-g']]:
36203618
args = opt + debug
36213619
print(args)
36223620
self.btest(path_from_root('tests', 'pthread', 'test_pthread_gcc_atomic_fetch_and_op.cpp'), expected='0', args=args + ['-s', 'INITIAL_MEMORY=64MB', '-s', 'USE_PTHREADS=1', '-s', 'PTHREAD_POOL_SIZE=8'])

0 commit comments

Comments
 (0)