Skip to content

Commit 6a3f818

Browse files
authored
Simplify test runner argument parsing. NFC (#21862)
1 parent 63c648f commit 6a3f818

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

test/runner.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -366,29 +366,29 @@ def run_tests(options, suites):
366366

367367
def parse_args(args):
368368
parser = argparse.ArgumentParser(prog='runner.py', description=__doc__)
369-
parser.add_argument('--save-dir', action='store_true', default=None,
369+
parser.add_argument('--save-dir', action='store_true',
370370
help='Save the temporary directory used during for each '
371371
'test. Implies --cores=1. Defaults to true when running a single test')
372372
parser.add_argument('--no-clean', action='store_true',
373373
help='Do not clean the temporary directory before each test run')
374-
parser.add_argument('--verbose', '-v', action='store_true', default=None)
375-
parser.add_argument('--all-engines', action='store_true', default=None)
376-
parser.add_argument('--detect-leaks', action='store_true', default=None)
374+
parser.add_argument('--verbose', '-v', action='store_true')
375+
parser.add_argument('--all-engines', action='store_true')
376+
parser.add_argument('--detect-leaks', action='store_true')
377377
parser.add_argument('--skip-slow', action='store_true', help='Skip tests marked as slow')
378378
parser.add_argument('--cores', '-j',
379379
help='Set the number tests to run in parallel. Defaults '
380380
'to the number of CPU cores.', default=None)
381-
parser.add_argument('--rebaseline', action='store_true', default=None,
381+
parser.add_argument('--rebaseline', action='store_true',
382382
help='Automatically update test expectations for tests that support it.')
383383
parser.add_argument('--browser',
384384
help='Command to launch web browser in which to run browser tests.')
385385
parser.add_argument('tests', nargs='*')
386-
parser.add_argument('--failfast', action='store_const', const=True, default=False)
386+
parser.add_argument('--failfast', action='store_true')
387387
parser.add_argument('--start-at', metavar='NAME', help='Skip all tests up until <NAME>')
388388
parser.add_argument('--continue', dest='_continue', action='store_true',
389389
help='Resume from the last run test.'
390390
'Useful when combined with --failfast')
391-
parser.add_argument('--force64', action='store_const', const=True, default=None)
391+
parser.add_argument('--force64', action='store_true')
392392
parser.add_argument('--crossplatform-only', action='store_true')
393393
parser.add_argument('--repeat', type=int, default=1,
394394
help='Repeat each test N times (default: 1).')

0 commit comments

Comments
 (0)