Revert "Bump min node version to 18.20.3 (#22010)" (#22023)

This is mostly a revert of commit 27b3050.

It reverts the min node version in emscripten, but keeps the CircleCI configuration to test with node 18.

This is a temporary workaround for #22022

Author: dschuff

site/source/docs/tools_reference/settings_reference.rst

@@ -2933,12 +2933,11 @@ MIN_NODE_VERSION
 
 Specifies minimum node version to target for the generated code.  This is
 distinct from the minimum version required run the emscripten compiler.
-This version aligns with the current Node LTS release, and the version
-of node that is included with emsdk.
-Version is encoded in MMmmVV, e.g. 181401 denotes Node 18.14.1.
+This version aligns with the current Ubuuntu TLS 20.04 (Focal).
+Version is encoded in MMmmVV, e.g. 181401 denotes Node 18.14.01.
 Minimum supported value is 101900, which was released 2020-02-05.
 
-Default value: 182003
+Default value: 160000
 
 .. _support_errno:
 

src/parseTools.mjs

@@ -1059,8 +1059,8 @@ function getEntryFunction() {
 }
 
 function formattedMinNodeVersion() {
-  var major = (MIN_NODE_VERSION / 10000) | 0;
-  var minor = ((MIN_NODE_VERSION / 100) | 0) % 100;
+  var major = MIN_NODE_VERSION / 10000;
+  var minor = (MIN_NODE_VERSION / 100) % 100;
   var rev = MIN_NODE_VERSION % 100;
   return `v${major}.${minor}.${rev}`;
 }

src/settings.js

@@ -1905,11 +1905,10 @@ var MIN_CHROME_VERSION = 85;
 
 // Specifies minimum node version to target for the generated code.  This is
 // distinct from the minimum version required run the emscripten compiler.
-// This version aligns with the current Node LTS release, and the version
-// of node that is included with emsdk.
-// Version is encoded in MMmmVV, e.g. 181401 denotes Node 18.14.1.
+// This version aligns with the current Ubuuntu TLS 20.04 (Focal).
+// Version is encoded in MMmmVV, e.g. 181401 denotes Node 18.14.01.
 // Minimum supported value is 101900, which was released 2020-02-05.
-var MIN_NODE_VERSION = 182003;
+var MIN_NODE_VERSION = 160000;
 
 // Whether we support setting errno from JS library code.
 // In MINIMAL_RUNTIME builds, this option defaults to 0.

test/other/metadce/test_metadce_hello_O0.gzsize

@@ -1 +1 @@
-8140
+8137

test/other/metadce/test_metadce_hello_O0.jssize

@@ -1 +1 @@
-22014
+22013

test/other/metadce/test_metadce_minimal_O0.gzsize

@@ -1 +1 @@
-6725
+6721

test/other/metadce/test_metadce_minimal_O0.jssize

@@ -1 +1 @@
-18122
+18121

test/other/test_unoptimized_code_size.js.size

@@ -1 +1 @@
-55521
+55520

test/other/test_unoptimized_code_size_strict.js.size

@@ -1 +1 @@
-54384
+54383

test/test_sanity.py

@@ -284,8 +284,8 @@ def test_node(self):
     for version, succeed in [('v0.8.0', False),
                              ('v4.1.0', False),
                              ('v10.18.0', False),
-                             ('v19.20.3', True),
-                             ('v19.20.4-pre', True),
+                             ('v16.20.0', True),
+                             ('v16.20.1-pre', True),
                              ('cheez', False)]:
       print(version, succeed)
       delete_file(SANITY_FILE)

tools/shared.py

@@ -58,7 +58,7 @@
 # (settings.MIN_NODE_VERSION).
 # This version currently matches the node version that we ship with emsdk
 # which means that we can say for sure that this version is well supported.
-MINIMUM_NODE_VERSION = (18, 20, 3)
+MINIMUM_NODE_VERSION = (16, 20, 0)
 EXPECTED_LLVM_VERSION = 19
 
 # These get set by setup_temp_dirs