Skip to content

Commit 783d0b8

Browse files
authored
[test] Temporarily disable wasm64 + threads browser test (#20263)
We are using `index: 'i64'` for our memory type which isn't currently compatible with the chrome unstable build we use in CI but will be once this change makes it into an unstable release: https://chromium-review.googlesource.com/c/v8/v8/+/4807493.
1 parent aab180a commit 783d0b8

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

test/test_browser.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4714,7 +4714,9 @@ def test_fetch_cached_xhr(self):
47144714

47154715
# Tests that response headers get set on emscripten_fetch_t values.
47164716
@no_firefox('https://github.com/emscripten-core/emscripten/issues/16868')
4717-
@also_with_wasm2js_or_wasm64
4717+
# TODO(sbc): https://github.com/emscripten-core/emscripten/issues/20262
4718+
# @also_with_wasm2js_or_wasm64
4719+
@also_with_wasm2js
47184720
@requires_threads
47194721
def test_fetch_response_headers(self):
47204722
shutil.copyfile(test_file('gears.png'), 'gears.png')
@@ -4747,7 +4749,9 @@ def test_fetch_xhr_abort(self):
47474749
# Tests emscripten_fetch() usage in synchronous mode when used from the main
47484750
# thread proxied to a Worker with -sPROXY_TO_PTHREAD option.
47494751
@no_firefox('https://github.com/emscripten-core/emscripten/issues/16868')
4750-
@also_with_wasm64
4752+
# TODO(sbc): https://github.com/emscripten-core/emscripten/issues/20262
4753+
# @also_with_wasm2js_or_wasm64
4754+
@also_with_wasm2js
47514755
@requires_threads
47524756
def test_fetch_sync_xhr(self):
47534757
shutil.copyfile(test_file('gears.png'), 'gears.png')
@@ -4756,7 +4760,8 @@ def test_fetch_sync_xhr(self):
47564760
# Tests emscripten_fetch() usage when user passes none of the main 3 flags (append/replace/no_download).
47574761
# In that case, in append is implicitly understood.
47584762
@no_firefox('https://github.com/emscripten-core/emscripten/issues/16868')
4759-
@also_with_wasm64
4763+
# TODO(sbc): https://github.com/emscripten-core/emscripten/issues/20262
4764+
# @also_with_wasm64
47604765
@requires_threads
47614766
def test_fetch_implicit_append(self):
47624767
shutil.copyfile(test_file('gears.png'), 'gears.png')
@@ -5589,7 +5594,8 @@ def test_full_js_library_strict(self):
55895594
# Tests the AudioWorklet demo
55905595
@parameterized({
55915596
'': ([],),
5592-
'memory64': (['-sMEMORY64', '-Wno-experimental'],),
5597+
# TODO(sbc): https://github.com/emscripten-core/emscripten/issues/20262
5598+
# 'memory64': (['-sMEMORY64', '-Wno-experimental'],),
55935599
'with_fs': (['--preload-file', test_file('hello_world.c') + '@/'],),
55945600
'closure': (['--closure', '1', '-Oz'],),
55955601
'asyncify': (['-sASYNCIFY'],),

0 commit comments

Comments
 (0)