Skip to content

Commit 7fe4690

Browse files
committed
Disable all dynamic linking tests under MEMORY64=2
Followup to ec14ddf and 20800de.
1 parent 4e8dc6f commit 7fe4690

File tree

2 files changed

+10
-12
lines changed

2 files changed

+10
-12
lines changed

test/common.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -795,6 +795,16 @@ def check_dylink(self):
795795
self.skipTest('no dynamic linking support in wasm2js yet')
796796
if '-fsanitize=undefined' in self.emcc_args:
797797
self.skipTest('no dynamic linking support in UBSan yet')
798+
# Temporarily enableing WASM_BIGINT in all dylink tests in order to allow
799+
# a recent llvm change to land:
800+
# https://github.com/llvm/llvm-project/pull/75242
801+
# Once that lands we can use --no-shlib-sigcheck instead.
802+
self.set_setting('WASM_BIGINT')
803+
# MEMORY64=2 mode doesn't currently support dynamic linking because
804+
# The side modules are lowered to wasm32 when they are built, making
805+
# them unlinkable with wasm64 binaries.
806+
if self.get_setting('MEMORY64') == 2:
807+
self.skipTest('MEMORY64=2 + dynamic linking is not currently supported')
798808

799809
def require_v8(self):
800810
if not config.V8_ENGINE or config.V8_ENGINE not in config.JS_ENGINES:

test/test_core.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3986,11 +3986,6 @@ def test_dlfcn_preload(self):
39863986

39873987
def dylink_test(self, main, side, expected=None, header=None, force_c=False,
39883988
main_module=2, **kwargs):
3989-
# Temporarily enableing WASM_BIGINT in all dylink tests in order to allow
3990-
# a recent llvm change to land:
3991-
# https://github.com/llvm/llvm-project/pull/75242
3992-
# Once that lands we can use --no-shlib-sigcheck instead.
3993-
self.set_setting('WASM_BIGINT')
39943989
# Same as dylink_testf but take source code in string form
39953990
if not isinstance(side, list):
39963991
side_file = 'liblib.cpp' if not force_c else 'liblib.c'
@@ -4010,13 +4005,6 @@ def dylink_testf(self, main, side=None, expected=None, force_c=False, main_emcc_
40104005
so_dir='',
40114006
so_name='liblib.so',
40124007
**kwargs):
4013-
# Temporarily enableing WASM_BIGINT in all dylink tests in order to allow
4014-
# a recent llvm change to land:
4015-
# https://github.com/llvm/llvm-project/pull/75242
4016-
# Once that lands we can use --no-shlib-sigcheck instead.
4017-
self.set_setting('WASM_BIGINT')
4018-
if self.get_setting('MEMORY64') == 2:
4019-
self.skipTest('MEMORY64=2 + dynamic linking is in flux')
40204008
main_emcc_args = main_emcc_args or []
40214009
if getattr(self, 'dylink_reversed', False):
40224010
# Test the reverse case. There we flip the role of the side module and main module.

0 commit comments

Comments
 (0)