Skip to content

Commit 89cbc4e

Browse files
authored
Remove unnecessary forced exports. NFC (#23060)
1 parent 0c51f74 commit 89cbc4e

File tree

4 files changed

+3
-7
lines changed

4 files changed

+3
-7
lines changed

src/library_pthread.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1000,7 +1000,7 @@ var LibraryPThread = {
10001000
},
10011001
10021002
$establishStackSpace__internal: true,
1003-
$establishStackSpace__deps: ['$stackRestore'],
1003+
$establishStackSpace__deps: ['$stackRestore', 'emscripten_stack_set_limits'],
10041004
$establishStackSpace: (pthread_ptr) => {
10051005
#if ALLOW_MEMORY_GROWTH
10061006
// If memory growth is enabled, the memory views may have gotten out of date,

test/other/codesize/test_codesize_minimal_pthreads.funcs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ $em_task_queue_free
6767
$em_task_queue_is_empty
6868
$emscripten_builtin_free
6969
$emscripten_builtin_malloc
70-
$emscripten_current_thread_process_queued_calls
7170
$emscripten_futex_wait
7271
$emscripten_futex_wake
7372
$emscripten_stack_get_current
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19501
1+
19495

tools/link.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -499,10 +499,6 @@ def setup_pthreads():
499499
settings.REQUIRED_EXPORTS += [
500500
'_emscripten_thread_free_data',
501501
'_emscripten_thread_crashed',
502-
'emscripten_main_runtime_thread_id',
503-
'emscripten_main_thread_process_queued_calls',
504-
'_emscripten_run_on_main_thread_js',
505-
'emscripten_stack_set_limits',
506502
]
507503

508504
if settings.EMBIND:
@@ -687,6 +683,7 @@ def phase_linker_setup(options, state, newargs):
687683
if not settings.ASSERTIONS:
688684
exit_with_error('PTHREADS_PROFILING only works with ASSERTIONS enabled')
689685
options.post_js.append(utils.path_from_root('src/threadprofiler.js'))
686+
settings.REQUIRED_EXPORTS.append('emscripten_main_runtime_thread_id')
690687

691688
options.extern_pre_js = read_js_files(options.extern_pre_js)
692689
options.extern_post_js = read_js_files(options.extern_post_js)

0 commit comments

Comments
 (0)