Skip to content

Commit adee9c8

Browse files
authored
Remove handling output from older versions of wasm-emscripten-finalize. NFC (#15924)
Older versions of this tool are not generally supported. This handling/ignoring of legacy keys useful for a a transition period but at this point versions of binaryen that are that old will have other compat issues.
1 parent 2885620 commit adee9c8

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

emscripten.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -780,20 +780,12 @@ def load_metadata_wasm(metadata_raw):
780780
'features': [],
781781
'mainReadsParams': 1,
782782
}
783-
legacy_keys = set(['implementedFunctions', 'initializers', 'simd', 'externs', 'staticBump', 'tableSize'])
784783

785784
for key, value in metadata_json.items():
786-
if key in legacy_keys:
787-
continue
788785
if key not in metadata:
789786
exit_with_error('unexpected metadata key received from wasm-emscripten-finalize: %s', key)
790787
metadata[key] = value
791788

792-
# Support older metadata when asmConsts values were lists. We only use the first element
793-
# nowadays
794-
# TODO(sbc): remove this once binaryen has been changed to only emit the single element
795-
metadata['asmConsts'] = {k: v[0] if type(v) is list else v for k, v in metadata['asmConsts'].items()}
796-
797789
if DEBUG:
798790
logger.debug("Metadata parsed: " + pprint.pformat(metadata))
799791

0 commit comments

Comments
 (0)