[library_openal] Simplify string operations. NFC (#22084)

Split out from #22067

Author: sbc100

src/library_openal.js

@@ -2408,7 +2408,7 @@ var LibraryOpenAL = {
     case 0x1005 /* ALC_DEVICE_SPECIFIER */:
       if (typeof AudioContext != 'undefined' ||
           typeof webkitAudioContext != 'undefined') {
-        ret = AL.DEVICE_NAME.concat('\0');
+        ret = AL.DEVICE_NAME + '\0';
       } else {
         ret = '\0';
       }
@@ -2417,9 +2417,9 @@ var LibraryOpenAL = {
       ret = AL.CAPTURE_DEVICE_NAME;
       break;
     case 0x310 /* ALC_CAPTURE_DEVICE_SPECIFIER */:
-      if (deviceId === 0)
-        ret = AL.CAPTURE_DEVICE_NAME.concat('\0');
-        else {
+      if (deviceId === 0) {
+        ret = AL.CAPTURE_DEVICE_NAME + '\0';
+      } else {
         var c = AL.requireValidCaptureDevice(deviceId, 'alcGetString');
         if (!c) {
           return 0;
@@ -2433,12 +2433,7 @@ var LibraryOpenAL = {
         return 0;
       }
 
-      ret = '';
-      for (var ext in AL.ALC_EXTENSIONS) {
-        ret = ret.concat(ext);
-        ret = ret.concat(' ');
-      }
-      ret = ret.trim();
+      ret = Object.keys(AL.ALC_EXTENSIONS).join(' ')
       break;
     default:
       AL.alcErr = {{{ cDefs.ALC_INVALID_ENUM }}};
@@ -3049,12 +3044,7 @@ var LibraryOpenAL = {
       ret = 'WebAudio';
       break;
     case 0xB004 /* AL_EXTENSIONS */:
-      ret = '';
-      for (var ext in AL.AL_EXTENSIONS) {
-        ret = ret.concat(ext);
-        ret = ret.concat(' ');
-      }
-      ret = ret.trim();
+      ret = Object.keys(AL.AL_EXTENSIONS).join(' ');
       break;
     default:
       if (AL.currentCtx) {

test/openal_extensions.c

@@ -33,17 +33,20 @@ static const ALCchar *al_extensions[NUM_AL_EXTENSIONS] = {
 };
 
 static void check_alc_extension(const ALCchar *extension) {
+  printf("checking: %s\n", extension);
   ALCdevice *device = alcOpenDevice(NULL);
 
   assert(device);
   assert(alcIsExtensionPresent(device, extension) == ALC_TRUE);
 }
 
 static void check_al_extension(const ALchar *extension) {
+  printf("checking: %s\n", extension);
   assert(alIsExtensionPresent(extension) == ALC_TRUE);
 }
 
 int main() {
+  printf("AL_EXTENSIONS: %s\n", alGetString(AL_EXTENSIONS));
 
   for (int i = 0; i < NUM_ALC_EXTENSIONS; i++) {
     check_alc_extension(alc_extensions[i]);
@@ -53,5 +56,6 @@ int main() {
     check_al_extension(al_extensions[i]);
   }
 
+  printf("done\n");
   return 0;
 }