Fix output location for dummy worker.js file (#21830)

Followup to #21701.

See: #21827

Author: sbc100

ChangeLog.md

@@ -20,6 +20,9 @@ See docs/process.md for more on how version tagging works.
 
 3.1.59 (in development)
 -----------------------
+- Fix the location of the dummy `.worker.js` file that is now generated as part
+  of pthread builds so that is generated alongside the main JavaScript file.
+  See #21701. ()
 
 3.1.58 - 04/23/24
 -----------------

test/test_other.py

@@ -14530,6 +14530,10 @@ def test_legacy_pthread_worker_js(self):
     self.assertNotExists('hello_world.worker.js')
     self.do_runf('hello_world.c', emcc_args=['-pthread'])
     self.assertExists('hello_world.worker.js')
+    os.mkdir('out')
+    self.do_runf('hello_world.c', output_basename='out/foo', emcc_args=['-pthread'])
+    self.assertExists('out/foo.js')
+    self.assertExists('out/foo.worker.js')
 
   def test_no_pthread(self):
     self.do_runf('hello_world.c', emcc_args=['-pthread', '-no-pthread'])

tools/link.py

@@ -2061,7 +2061,8 @@ def phase_final_emitting(options, state, target, wasm_target):
 
   target_dir = os.path.dirname(os.path.abspath(target))
   if settings.PTHREADS and not settings.STRICT:
-    write_file(unsuffixed_basename(target) + '.worker.js', '''\
+    worker_file = shared.replace_suffix(target, get_worker_js_suffix())
+    write_file(worker_file, '''\
 // This file is no longer used by emscripten and has been created as a placeholder
 // to allow build systems to transition away from depending on it.
 //