strndump function implementation #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
strndup in The Open Group Technical Standard: http://pubs.opengroup.org/onlinepubs/9699919799/functions/strndup.html |
| strndup: function(ptr, size) { | ||
| var len = String_len(ptr); | ||
|
|
||
| if (size <= 0 || size >= len) { |
There was a problem hiding this comment.
I think the check <=0 might be wrong. If size is 0, but len is larger than 0, then what will happen here is we copy the entire original string. But we should copy 0 bytes of it, that is, just return a new string of size 0 (just a null terminator).
If I am not mistaken, just removing the size <= 0 condition will make this work ok. If size is 0, the processing after it will work ok.
There was a problem hiding this comment.
You right. I will fix it. And when size < 0 i assume that strndup should also return empty string.
|
Now problem with zero and negative size are fixed. |
kripken
added a commit
that referenced
this pull request
May 30, 2012
strndump function implementation
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add strndup function implementation (in src/library.js) and test for it (in runner.py). Also add Aleksandr Guraynov to the AUTHORS as said in wiki.
I dont know is this function exists on MacOS and Window. May be some checks need to be added.