Cleaner handling of clusure compiler errors #7313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously you would see an emscripten internal backtrace if closure compiler failed. Sadly we have a lot of existing warnings so we don't display the process stderr unless we the subprcess returns non-zero. I guess we should try to address the closure warnings, at least the ones in emscripten proper.
kripken
approved these changes
Oct 19, 2018
Mstrodl
pushed a commit
to Mstrodl/emscripten
that referenced
this pull request
Oct 21, 2018
Previously you would see an emscripten internal backtrace if closure compiler failed. Sadly we have a lot of existing warnings so we don't display the process stderr unless we the subprcess returns non-zero. I guess we should try to address the closure warnings, at least the ones in emscripten proper.
Beuc
pushed a commit
to Beuc/emscripten
that referenced
this pull request
Nov 17, 2018
Previously you would see an emscripten internal backtrace if closure compiler failed. Sadly we have a lot of existing warnings so we don't display the process stderr unless we the subprcess returns non-zero. I guess we should try to address the closure warnings, at least the ones in emscripten proper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously you would see an emscripten internal backtrace
if closure compiler failed.
Sadly we have a lot of existing warnings so we don't display
the process stderr unless we the subprcess returns non-zero.
I guess we should try to address the closure warnings, at least
the ones in emscripten proper.