Skip to content

Commit 267b97d

Browse files
committed
adjust GitHub actions to test Django versions
1 parent 22dd853 commit 267b97d

File tree

2 files changed

+79
-15
lines changed

2 files changed

+79
-15
lines changed

.github/workflows/main.yml

Lines changed: 69 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,56 @@ on:
88

99
jobs:
1010
tests:
11-
name: Python ${{ matrix.python-version }}
11+
name: Python ${{ matrix.python-version }}, Django ${{ matrix.django-version }}, TOXENV ${{ matrix.tox-env }}
1212
runs-on: ubuntu-20.04
1313

1414
strategy:
15+
fail-fast: false
1516
matrix:
17+
django-version:
18+
- '3.1'
19+
- '3.2'
1620
python-version:
1721
- '3.6'
1822
- '3.7'
1923
- '3.8'
2024
- '3.9'
25+
# GitHub Actions do not seem to play well with "default" matrix values
26+
# so use N/A instead.
27+
tox-env:
28+
- 'N/A'
29+
30+
include:
31+
# Old Django LTS only on older Pythons
32+
- django-version: '2.2'
33+
python-version: '3.6'
34+
tox-env: 'N/A'
35+
36+
- django-version: '2.2'
37+
python-version: '3.7'
38+
tox-env: 'N/A'
39+
40+
# Pre-release Django only on new Pythons
41+
- django-version: 'main'
42+
python-version: '3.8'
43+
tox-env: 'N/A'
44+
45+
- django-version: 'main'
46+
python-version: '3.9'
47+
tox-env: 'N/A'
48+
49+
# Explicit tox envs
50+
- django-version: 'N/A'
51+
python-version: '3.9'
52+
tox-env: 'base'
53+
54+
- django-version: 'N/A'
55+
python-version: '3.9'
56+
tox-env: 'docs'
57+
58+
- django-version: 'N/A'
59+
python-version: '3.9'
60+
tox-env: 'dist'
2161

2262
steps:
2363
- uses: actions/checkout@v2
@@ -33,25 +73,41 @@ jobs:
3373
restore-keys: |
3474
${{ runner.os }}-pip-
3575
36-
- name: Upgrade packaging tools
37-
run: python -m pip install --upgrade pip setuptools virtualenv wheel
38-
3976
- name: Install dependencies
40-
run: python -m pip install --upgrade codecov tox
77+
run: |
78+
python -m pip install --upgrade pip setuptools virtualenv wheel
79+
python -m pip install --upgrade codecov tox tox-gh-actions
4180
42-
- name: Run tox targets for ${{ matrix.python-version }}
81+
- name: Run tox
82+
if: ${{ matrix.tox-env == 'N/A' }}
4383
run: |
44-
ENV_PREFIX=$(tr -C -d "0-9" <<< "${{ matrix.python-version }}")
45-
TOXENV=$(tox --listenvs | grep "^py$ENV_PREFIX" | tr '\n' ',') tox
84+
tox
85+
env:
86+
DJANGO: ${{ matrix.django-version }}
4687

88+
# This would not be needed after https://github.com/ymyzk/tox-gh-actions/pull/60
89+
# but it may need adjustment for --installpkg
4790
- name: Run extra tox targets
48-
if: ${{ matrix.python-version == '3.9' }}
91+
if: ${{ matrix.tox-env != 'N/A' }}
4992
run: |
50-
python setup.py bdist_wheel
51-
rm -r djangorestframework.egg-info # see #6139
52-
tox -e base,dist,docs
53-
tox -e dist --installpkg ./dist/djangorestframework-*.whl
93+
ARGS=()
94+
if [[ $TOXENV == 'dist' ]]; then
95+
# see https://github.com/encode/django-rest-framework/pull/6139
96+
python setup.py bdist_wheel
97+
rm -r djangorestframework.egg-info
98+
ARGS=(--installpkg ./dist/djangorestframework-*.whl)
99+
fi
100+
101+
tox "${ARGS[@]}"
102+
env:
103+
TOXENV: ${{ matrix.tox-env }}
54104

55105
- name: Upload coverage
56106
run: |
107+
# Remove sentinel values
108+
[[ $TOXENV == 'N/A' ]] && unset TOXENV
109+
[[ $DJANGO == 'N/A' ]] && unset DJANGO
57110
codecov -e TOXENV,DJANGO
111+
env:
112+
DJANGO: ${{ matrix.django-version }}
113+
TOXENV: ${{ matrix.tox-env }}

tox.ini

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,18 @@ envlist =
77
{py38,py39}-djangomain,
88
base,dist,docs,
99

10-
[travis:env]
10+
[gh-actions]
11+
python =
12+
3.6: py36
13+
3.7: py37
14+
3.8: py38
15+
3.9: py39
16+
# This needs https://github.com/ymyzk/tox-gh-actions/pull/60
17+
# 3.9: py39,base,dist,docs
18+
19+
[gh-actions:env]
1120
DJANGO =
1221
2.2: django22
13-
3.0: django30
1422
3.1: django31
1523
3.2: django32
1624
main: djangomain

0 commit comments

Comments
 (0)