Merge pull request #3238 from kezabelle/bugfix/3235

Fixed #3235 - ListField now returns the QueryDict value even if it's a list of only one item.

Author: tomchristie

rest_framework/fields.py

@@ -1391,7 +1391,7 @@ def get_value(self, dictionary):
         # lists in HTML forms.
         if html.is_html_input(dictionary):
             val = dictionary.getlist(self.field_name, [])
-            if len(val) > 1:
+            if len(val) > 0:
                 # Support QueryDict lists in HTML input.
                 return val
             return html.parse_html_list(dictionary, prefix=self.field_name)

tests/test_fields.py

@@ -317,6 +317,14 @@ class TestSerializer(serializers.Serializer):
         assert serializer.is_valid()
         assert serializer.validated_data == {'scores': [1, 3]}
 
+    def test_querydict_list_input_only_one_input(self):
+        class TestSerializer(serializers.Serializer):
+            scores = serializers.ListField(child=serializers.IntegerField())
+
+        serializer = TestSerializer(data=QueryDict('scores=1&'))
+        assert serializer.is_valid()
+        assert serializer.validated_data == {'scores': [1]}
+
 
 class TestCreateOnlyDefault:
     def setup(self):