FloatField will crash if the input is a number that is too big

Author: winmorre

rest_framework/fields.py

@@ -104,7 +104,8 @@ def get_attribute(instance, attrs):
                 # If we raised an Attribute or KeyError here it'd get treated
                 # as an omitted field in `Field.get_attribute()`. Instead we
                 # raise a ValueError to ensure the exception is not masked.
-                raise ValueError('Exception raised in callable attribute "{}"; original exception was: {}'.format(attr, exc))
+                raise ValueError(
+                    'Exception raised in callable attribute "{}"; original exception was: {}'.format(attr, exc))
 
     return instance
 
@@ -181,6 +182,7 @@ def iter_options(grouped_choices, cutoff=None, cutoff_text=None):
     """
     Helper function for options and option groups in templates.
     """
+
     class StartOptionGroup:
         start_option_group = True
         end_option_group = False
@@ -366,10 +368,10 @@ def bind(self, field_name, parent):
         # 'source' argument has been used. For example:
         # my_field = serializer.CharField(source='my_field')
         assert self.source != field_name, (
-            "It is redundant to specify `source='%s'` on field '%s' in "
-            "serializer '%s', because it is the same as the field name. "
-            "Remove the `source` keyword argument." %
-            (field_name, self.__class__.__name__, parent.__class__.__name__)
+                "It is redundant to specify `source='%s'` on field '%s' in "
+                "serializer '%s', because it is the same as the field name. "
+                "Remove the `source` keyword argument." %
+                (field_name, self.__class__.__name__, parent.__class__.__name__)
         )
 
         self.field_name = field_name
@@ -794,7 +796,8 @@ def __init__(self, allow_unicode=False, **kwargs):
         super().__init__(**kwargs)
         self.allow_unicode = allow_unicode
         if self.allow_unicode:
-            validator = RegexValidator(re.compile(r'^[-\w]+\Z', re.UNICODE), message=self.error_messages['invalid_unicode'])
+            validator = RegexValidator(re.compile(r'^[-\w]+\Z', re.UNICODE),
+                                       message=self.error_messages['invalid_unicode'])
         else:
             validator = RegexValidator(re.compile(r'^[-a-zA-Z0-9_]+$'), message=self.error_messages['invalid'])
         self.validators.append(validator)
@@ -943,7 +946,7 @@ def to_internal_value(self, data):
 
         try:
             return float(data)
-        except (TypeError, ValueError):
+        except (TypeError, ValueError, OverflowError):
             self.fail('invalid')
 
     def to_representation(self, value):
@@ -994,7 +997,7 @@ def __init__(self, max_digits, decimal_places, coerce_to_string=None, max_value=
         if rounding is not None:
             valid_roundings = [v for k, v in vars(decimal).items() if k.startswith('ROUND_')]
             assert rounding in valid_roundings, (
-                'Invalid rounding option %s. Valid values for rounding are: %s' % (rounding, valid_roundings))
+                    'Invalid rounding option %s. Valid values for rounding are: %s' % (rounding, valid_roundings))
         self.rounding = rounding
 
     def validate_empty_values(self, data):
@@ -1732,6 +1735,7 @@ def __new__(cls, value):
                     ret = str.__new__(cls, value)
                     ret.is_json_string = True
                     return ret
+
             return JSONString(dictionary[self.field_name])
         return dictionary.get(self.field_name, empty)
 
@@ -1785,6 +1789,7 @@ class HiddenField(Field):
     constraint on a pair of fields, as we need some way to include the date in
     the validated data.
     """
+
     def __init__(self, **kwargs):
         assert 'default' in kwargs, 'default is a required argument.'
         kwargs['write_only'] = True
@@ -1814,6 +1819,7 @@ class ExampleSerializer(Serializer):
         def get_extra_info(self, obj):
             return ...  # Calculate some data to return.
     """
+
     def __init__(self, method_name=None, **kwargs):
         self.method_name = method_name
         kwargs['source'] = '*'