Skip to content

Commit 9cb547b

Browse files
author
Rense VanderHoek
committed
Validator-fix, added min/max fields to test_metadata
1 parent c8609ba commit 9cb547b

File tree

2 files changed

+15
-6
lines changed

2 files changed

+15
-6
lines changed

rest_framework/fields.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -738,10 +738,10 @@ def __init__(self, max_digits, decimal_places, coerce_to_string=None, max_value=
738738
super(DecimalField, self).__init__(**kwargs)
739739
if self.max_value is not None:
740740
message = self.error_messages['max_value'].format(max_value=self.max_value)
741-
self.validators.append(MaxValueValidator(max_value, message=message))
741+
self.validators.append(MaxValueValidator(self.max_value, message=message))
742742
if self.min_value is not None:
743743
message = self.error_messages['min_value'].format(min_value=self.min_value)
744-
self.validators.append(MinValueValidator(min_value, message=message))
744+
self.validators.append(MinValueValidator(self.min_value, message=message))
745745

746746
def to_internal_value(self, data):
747747
"""

tests/test_metadata.py

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,12 @@ def test_actions(self):
5454
"""
5555
class ExampleSerializer(serializers.Serializer):
5656
choice_field = serializers.ChoiceField(['red', 'green', 'blue'])
57-
integer_field = serializers.IntegerField(max_value=10)
58-
char_field = serializers.CharField(required=False)
57+
integer_field = serializers.IntegerField(
58+
min_value=1, max_value=1000
59+
)
60+
char_field = serializers.CharField(
61+
required=False, min_length=3, max_length=40
62+
)
5963

6064
class ExampleView(views.APIView):
6165
"""Example view."""
@@ -96,13 +100,18 @@ def get_serializer(self):
96100
'type': 'integer',
97101
'required': True,
98102
'read_only': False,
99-
'label': 'Integer field'
103+
'label': 'Integer field',
104+
'min_value': 1,
105+
'max_value': 1000,
106+
100107
},
101108
'char_field': {
102109
'type': 'string',
103110
'required': False,
104111
'read_only': False,
105-
'label': 'Char field'
112+
'label': 'Char field',
113+
'min_length': 3,
114+
'max_length': 40
106115
}
107116
}
108117
}

0 commit comments

Comments
 (0)