Drop get_iterable()

Author: tomchristie

rest_framework/relations.py

@@ -88,7 +88,7 @@ def use_pk_only_optimization(self):
         return False
 
     def get_attribute(self, instance):
-        if self.use_pk_only_optimization():
+        if self.use_pk_only_optimization() and self.source_attrs:
             try:
                 # Optimized case, return a mock object only containing the pk attribute.
                 instance = get_attribute(instance, self.source_attrs[:-1])
@@ -99,10 +99,6 @@ def get_attribute(self, instance):
         # Standard case, return the object instance.
         return get_attribute(instance, self.source_attrs)
 
-    def get_iterable(self, instance, source_attrs):
-        relationship = get_attribute(instance, source_attrs)
-        return relationship.all() if (hasattr(relationship, 'all')) else relationship
-
     @property
     def choices(self):
         return dict([
@@ -349,7 +345,8 @@ def to_internal_value(self, data):
         ]
 
     def get_attribute(self, instance):
-        return self.child_relation.get_iterable(instance, self.source_attrs)
+        relationship = get_attribute(instance, self.source_attrs)
+        return relationship.all() if (hasattr(relationship, 'all')) else relationship
 
     def to_representation(self, iterable):
         return [