fix(ObtainAuthToken): Fix openapi schema generation

fix(ObtainAuthToken): Fix openapi response type
fix(ObtainAuthToken): Use APIView and define get_serializer
fix test

Author: gnuletik

rest_framework/authtoken/serializers.py

@@ -5,11 +5,19 @@
 
 
 class AuthTokenSerializer(serializers.Serializer):
-    username = serializers.CharField(label=_("Username"))
+    username = serializers.CharField(
+        label=_("Username"),
+        write_only=True
+    )
     password = serializers.CharField(
         label=_("Password"),
         style={'input_type': 'password'},
-        trim_whitespace=False
+        trim_whitespace=False,
+        write_only=True
+    )
+    token = serializers.CharField(
+        label=_("Token"),
+        read_only=True
     )
 
     def validate(self, attrs):

rest_framework/authtoken/views.py

@@ -4,6 +4,7 @@
 from rest_framework.compat import coreapi, coreschema
 from rest_framework.response import Response
 from rest_framework.schemas import ManualSchema
+from rest_framework.schemas import coreapi as coreapi_schema
 from rest_framework.views import APIView
 
 
@@ -13,7 +14,8 @@ class ObtainAuthToken(APIView):
     parser_classes = (parsers.FormParser, parsers.MultiPartParser, parsers.JSONParser,)
     renderer_classes = (renderers.JSONRenderer,)
     serializer_class = AuthTokenSerializer
-    if coreapi is not None and coreschema is not None:
+
+    if coreapi_schema.is_enabled():
         schema = ManualSchema(
             fields=[
                 coreapi.Field(
@@ -38,9 +40,19 @@ class ObtainAuthToken(APIView):
             encoding="application/json",
         )
 
+    def get_serializer_context(self):
+        return {
+            'request': self.request,
+            'format': self.format_kwarg,
+            'view': self
+        }
+
+    def get_serializer(self, *args, **kwargs):
+        kwargs['context'] = self.get_serializer_context()
+        return self.serializer_class(*args, **kwargs)
+
     def post(self, request, *args, **kwargs):
-        serializer = self.serializer_class(data=request.data,
-                                           context={'request': request})
+        serializer = self.get_serializer(data=request.data)
         serializer.is_valid(raise_exception=True)
         user = serializer.validated_data['user']
         token, created = Token.objects.get_or_create(user=user)

tests/schemas/test_openapi.py

@@ -7,6 +7,7 @@
 from django.utils.translation import gettext_lazy as _
 
 from rest_framework import filters, generics, pagination, routers, serializers
+from rest_framework.authtoken.views import obtain_auth_token
 from rest_framework.compat import uritemplate
 from rest_framework.parsers import JSONParser, MultiPartParser
 from rest_framework.renderers import JSONRenderer, OpenAPIRenderer
@@ -819,6 +820,7 @@ class ExampleStringTagsViewSet(views.ExampleGenericViewSet):
 
     def test_auto_generated_apiview_tags(self):
         class RestaurantAPIView(views.ExampleGenericAPIView):
+            schema = AutoSchema(operation_id_base="restaurant")
             pass
 
         class BranchAPIView(views.ExampleGenericAPIView):
@@ -932,3 +934,35 @@ def test_schema_information_empty(self):
 
         assert schema['info']['title'] == ''
         assert schema['info']['version'] == ''
+
+    def test_authtoken_serializer(self):
+        patterns = [
+            url(r'^api-token-auth/', obtain_auth_token)
+        ]
+        generator = SchemaGenerator(patterns=patterns)
+
+        request = create_request('/')
+        schema = generator.get_schema(request=request)
+
+        print(schema)
+
+        route = schema['paths']['/api-token-auth/']['post']
+
+        body_schema = route['requestBody']['content']['application/json']['schema']
+        assert body_schema == {
+            'type': 'object',
+            'properties': {
+                'username': {'type': 'string', 'writeOnly': True},
+                'password': {'type': 'string', 'writeOnly': True},
+            },
+            'required': ['username', 'password']
+        }
+
+        response_schema = route['responses']['201']['content']['application/json']['schema']
+        assert response_schema == {
+            'type': 'object',
+            'properties': {
+                'token': {'type': 'string', 'readOnly': True},
+            },
+            'required': []
+        }