Skip to content

Commit e44d8de

Browse files
committed
Fix pagination tests
1 parent df5d07a commit e44d8de

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

rest_framework/pagination.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -621,7 +621,7 @@ def paginate_queryset(self, queryset, request, view=None):
621621
queryset = queryset.order_by(*self.ordering)
622622

623623
# If we have a cursor with a fixed position then filter by that.
624-
if current_position is not None:
624+
if str(current_position) != 'None':
625625
order = self.ordering[0]
626626
is_reversed = order.startswith('-')
627627
order_attr = order.lstrip('-')

tests/test_pagination.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -951,17 +951,21 @@ class MockQuerySet:
951951
def __init__(self, items):
952952
self.items = items
953953

954-
def filter(self, created__gt=None, created__lt=None):
954+
def filter(self, q):
955+
q_args = dict(q.deconstruct()[1])
956+
created__gt = q_args.get('created__gt')
957+
created__lt = q_args.get('created__lt')
958+
955959
if created__gt is not None:
956960
return MockQuerySet([
957961
item for item in self.items
958-
if item.created > int(created__gt)
962+
if item.created is None or item.created > int(created__gt)
959963
])
960964

961965
assert created__lt is not None
962966
return MockQuerySet([
963967
item for item in self.items
964-
if item.created < int(created__lt)
968+
if item.created is None or item.created < int(created__lt)
965969
])
966970

967971
def order_by(self, *ordering):

0 commit comments

Comments
 (0)