Skip to content

Added validation exceptions for required fields with allow_blank set to True to mirror Django's validation logic #2021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Added validation exceptions for required fields with allow_blank set to True to mirror Django's validation logic #2021

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fc253d
Added validation exceptions for required fields with allow_blank set …
Nov 4, 2014
026f164
Stupidly referenced an attribute that will not always be populated. …
Nov 4, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rest_framework/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ def run_validation(self, data=empty):
if data is empty:
if getattr(self.root, 'partial', False):
raise SkipField()
if self.required:
if self.required and not getattr(self, 'allow_blank', None):
self.fail('required')
return self.get_default()

Expand Down