Skip to content

Proper import of errors from oauth_provider #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2013

Conversation

atlefren
Copy link
Contributor

@atlefren atlefren commented Apr 3, 2013

Fix the fact that InvalidConsumerError and InvalidTokenError wasn't imported correctly from oauth_provider. ref https://groups.google.com/forum/?fromgroups=#!topic/django-rest-framework/V5kVUQchSec

@tomchristie
Copy link
Member

There's one other place where oauth_provider_store is used. Is it possible to also change that one and then drop the oauth_provider_store import completely?

@atlefren
Copy link
Contributor Author

atlefren commented Apr 3, 2013

as far as i can see, oauth_provider_store is now used three places in authenticate.py:

  • get_consumer
  • get_access_token
  • check_nonce

I guess it could be possible to import just oauth_provider, and somehow call
oauth_provider.store.store.get_consumer()

etc..

though, I'm not quite sure of this, and I am a but relucatant to mess around too much with code I really don't know that well

tomchristie added a commit that referenced this pull request Apr 3, 2013
Proper import of errors from oauth_provider
@tomchristie tomchristie merged commit cb20216 into encode:master Apr 3, 2013
tomchristie added a commit that referenced this pull request Apr 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants