Skip to content

Commit 1f09e2c

Browse files
committed
Include HOME in build environment
Many of the tools run by p4a store intermediate files in the user's home directory. Passing the HOME environment variable to the build environment has 2 positive effects: 1. To completely encapsulate the build, HOME can be set to an alternate directory than the user's actual home directory. Many tools such as p4a have options to override these paths, but that must be done on a case by case basis and it would require that p4a pass through these options or environment variables. 2. In containerized environments the user may not be registered in the accounts database. If the user's home directory can't be found from the HOME environment variable or the accounts database, many tools will fail. An example of this is python2.7 when run by `ndk-build`.
1 parent b0ad428 commit 1f09e2c

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

pythonforandroid/archs.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,10 @@ def get_clang_exe(self, with_target=False, plus_plus=False):
140140
def get_env(self, with_flags_in_cc=True):
141141
env = {}
142142

143+
# HOME: User's home directory
144+
if 'HOME' in environ:
145+
env['HOME'] = environ['HOME']
146+
143147
# CFLAGS/CXXFLAGS: the processor flags
144148
env['CFLAGS'] = ' '.join(self.common_cflags).format(target=self.target)
145149
if self.arch_cflags:

0 commit comments

Comments
 (0)