mybatis#101: Remove experimental flag

- We are sure that this path is not invoked by current versions of mybatis,
and if it was, iut would have failed, it is thus safe to remove the flag

Author: epochcoder

src/main/java/org/apache/ibatis/builder/xml/XMLConfigBuilder.java

@@ -292,8 +292,6 @@ private void settingsElement(Properties props) {
         booleanValueOf(props.getProperty("argNameBasedConstructorAutoMapping"), false));
     configuration.setDefaultSqlProviderType(resolveClass(props.getProperty("defaultSqlProviderType")));
     configuration.setNullableOnForEach(booleanValueOf(props.getProperty("nullableOnForEach"), false));
-    configuration.setExperimentalConstructorCollectionMapping(
-        booleanValueOf(props.getProperty("experimentalConstructorCollectionMapping"), false));
   }
 
   private void environmentsElement(XNode context) throws Exception {

src/main/java/org/apache/ibatis/mapping/ResultMap.java

@@ -114,12 +114,10 @@ public ResultMap build() {
           resultMap.constructorResultMappings.add(resultMapping);
 
           // #101
-          if (resultMap.configuration.isExperimentalConstructorCollectionMappingEnabled()) {
-            Class<?> javaType = resultMapping.getJavaType();
-            resultMap.hasResultMapsUsingConstructorCollection = resultMap.hasResultMapsUsingConstructorCollection
-                || (resultMapping.getNestedQueryId() == null && javaType != null
-                    && resultMap.configuration.getObjectFactory().isCollection(javaType));
-          }
+          Class<?> javaType = resultMapping.getJavaType();
+          resultMap.hasResultMapsUsingConstructorCollection = resultMap.hasResultMapsUsingConstructorCollection
+              || (resultMapping.getNestedQueryId() == null && javaType != null
+                  && resultMap.configuration.getObjectFactory().isCollection(javaType));
 
           if (resultMapping.getProperty() != null) {
             constructorArgNames.add(resultMapping.getProperty());

src/main/java/org/apache/ibatis/session/Configuration.java

@@ -117,7 +117,6 @@ public class Configuration {
   protected boolean shrinkWhitespacesInSql;
   protected boolean nullableOnForEach;
   protected boolean argNameBasedConstructorAutoMapping;
-  protected boolean experimentalConstructorCollectionMapping;
 
   protected String logPrefix;
   protected Class<? extends Log> logImpl;
@@ -370,14 +369,6 @@ public boolean isSafeRowBoundsEnabled() {
     return safeRowBoundsEnabled;
   }
 
-  public void setExperimentalConstructorCollectionMapping(boolean experimentalConstructorCollectionMapping) {
-    this.experimentalConstructorCollectionMapping = experimentalConstructorCollectionMapping;
-  }
-
-  public boolean isExperimentalConstructorCollectionMappingEnabled() {
-    return experimentalConstructorCollectionMapping;
-  }
-
   public void setSafeRowBoundsEnabled(boolean safeRowBoundsEnabled) {
     this.safeRowBoundsEnabled = safeRowBoundsEnabled;
   }

src/site/markdown/configuration.md

@@ -137,7 +137,6 @@ These are extremely important tweaks that modify the way that MyBatis behaves at
 | defaultSqlProviderType                   | Specifies an sql provider class that holds provider method (Since 3.5.6). This class apply to the `type`(or `value`) attribute on sql provider annotation(e.g. `@SelectProvider`), when these attribute was omitted.                                                                                                                                                                                                                             | A type alias or fully qualified class name                                                                                                 | Not set                                               |
 | nullableOnForEach                        | Specifies the default value of 'nullable' attribute on 'foreach' tag. (Since 3.5.9)                                                                                                                                                                                                                                                                                                                                                              | true | false                                                                                                                          | false                                                 |
 | argNameBasedConstructorAutoMapping       | When applying constructor auto-mapping, argument name is used to search the column to map instead of relying on the column order. (Since 3.5.10)                                                                                                                                                                                                                                                                                                 | true | false                                                                                                                          | false                                                 |
-| experimentalConstructorCollectionMapping | When applying constructor mapping and any nested result mappings containing collections are found, they will now be filled (Since 3.6.0)                                                                                                                                                                                                                                                                                                         | true | false                                                                                                                          | false                                                 |
 
 An example of the settings element fully configured is as follows: