Skip to content

Commit 041d841

Browse files
Cohen-Carlislecmccandless
authored andcommitted
improve test descriptions re: absence of letters (#1282)
I ran across a solution that passed the tests but violated the spirit of the tests. The student was checking for shouting by checking for: * the absence of lower case letters AND * (a string ending in `!` OR * a string without numbers) This means that "1,2,3!" would be shouting, but "JUST 1 NUMBER" wouldn't, which seems to violate the spirit of tests titled: * shouting numbers * shouting with no exclamation mark
1 parent 50631fd commit 041d841

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

exercises/bob/canonical-data.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"exercise": "bob",
3-
"version": "1.2.0",
3+
"version": "1.2.1",
44
"cases": [
55
{
66
"description": "stating something",
@@ -83,15 +83,15 @@
8383
"expected": "Whoa, chill out!"
8484
},
8585
{
86-
"description": "only numbers",
86+
"description": "no letters",
8787
"property": "response",
8888
"input": {
8989
"heyBob": "1, 2, 3"
9090
},
9191
"expected": "Whatever."
9292
},
9393
{
94-
"description": "question with only numbers",
94+
"description": "question with no letters",
9595
"property": "response",
9696
"input": {
9797
"heyBob": "4?"

0 commit comments

Comments
 (0)