Skip to content

Commit bb6ac2d

Browse files
author
Daniele Esposti
committed
Call setData() only if proxy's data is not null
1 parent df90b7c commit bb6ac2d

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

src/puremvc/patterns/proxy.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ def __init__(self, proxyName=None, data=None):
4242
if proxyName is None:
4343
raise ValueError("Proxy name cannot be None")
4444
self.proxyName = proxyName
45-
self.setData(data)
45+
if data is not None:
46+
self.setData(data)
4647

4748
def getProxyName(self):
4849
"""

tests/patterns/proxy.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,3 +35,13 @@ def testConstructor(self):
3535
self.assertEqual(True, data[0] == 'red')
3636
self.assertEqual(True, data[1] == 'green')
3737
self.assertEqual(True, data[2] == 'blue')
38+
39+
def testEmptyData(self):
40+
"""ProxyTest: Test Constructor with not-null empty data"""
41+
42+
values = ["", (), []]
43+
44+
for value in values:
45+
proxy = puremvc.patterns.proxy.Proxy("empty", value)
46+
47+
self.assertEqual(proxy.data, value)

0 commit comments

Comments
 (0)