Rename Patcher to ValueGetter

Author: rrb3942

patchers/value/bench_test.go

@@ -14,7 +14,7 @@ func Benchmark_valueAdd(b *testing.B) {
 	env["ValueOne"] = &customInt{1}
 	env["ValueTwo"] = &customInt{2}
 
-	program, err := expr.Compile("ValueOne + ValueTwo", expr.Env(env), Patcher)
+	program, err := expr.Compile("ValueOne + ValueTwo", expr.Env(env), ValueGetter)
 	require.NoError(b, err)
 
 	var out any
@@ -35,7 +35,7 @@ func Benchmark_valueUntypedAdd(b *testing.B) {
 	env["ValueOne"] = &customUntypedInt{1}
 	env["ValueTwo"] = &customUntypedInt{2}
 
-	program, err := expr.Compile("ValueOne + ValueTwo", expr.Env(env), Patcher)
+	program, err := expr.Compile("ValueOne + ValueTwo", expr.Env(env), ValueGetter)
 	require.NoError(b, err)
 
 	var out any
@@ -56,7 +56,7 @@ func Benchmark_valueTypedAdd(b *testing.B) {
 	env["ValueOne"] = &customTypedInt{1}
 	env["ValueTwo"] = &customTypedInt{2}
 
-	program, err := expr.Compile("ValueOne + ValueTwo", expr.Env(env), Patcher)
+	program, err := expr.Compile("ValueOne + ValueTwo", expr.Env(env), ValueGetter)
 	require.NoError(b, err)
 
 	var out any

patchers/value/value.go

@@ -54,7 +54,7 @@ import (
 
 // Patcher is an expr.Option that both patches the program and adds the `$patcher_value_getter` function.
 // Use it directly as an Option to expr.Compile()
-var Patcher = func() expr.Option {
+var ValueGetter = func() expr.Option {
 	vPatcher := patcher{}
 	return func(c *conf.Config) {
 		c.Visitors = append(c.Visitors, vPatcher)

patchers/value/value_test.go

@@ -86,7 +86,7 @@ func Test_valueAddInt(t *testing.T) {
 	env["ValueOne"] = &customInt{1}
 	env["ValueTwo"] = &customInt{2}
 
-	program, err := expr.Compile("ValueOne + ValueTwo", expr.Env(env), Patcher)
+	program, err := expr.Compile("ValueOne + ValueTwo", expr.Env(env), ValueGetter)
 	require.NoError(t, err)
 
 	out, err := vm.Run(program, env)
@@ -100,7 +100,7 @@ func Test_valueUntypedAddInt(t *testing.T) {
 	env["ValueOne"] = &customUntypedInt{1}
 	env["ValueTwo"] = &customUntypedInt{2}
 
-	program, err := expr.Compile("ValueOne + ValueTwo", expr.Env(env), Patcher)
+	program, err := expr.Compile("ValueOne + ValueTwo", expr.Env(env), ValueGetter)
 	require.NoError(t, err)
 
 	out, err := vm.Run(program, env)
@@ -114,7 +114,7 @@ func Test_valueTypedAddInt(t *testing.T) {
 	env["ValueOne"] = &customTypedInt{1}
 	env["ValueTwo"] = &customTypedInt{2}
 
-	program, err := expr.Compile("ValueOne + ValueTwo", expr.Env(env), Patcher)
+	program, err := expr.Compile("ValueOne + ValueTwo", expr.Env(env), ValueGetter)
 	require.NoError(t, err)
 
 	out, err := vm.Run(program, env)
@@ -128,7 +128,7 @@ func Test_valueTypedAddMismatch(t *testing.T) {
 	env["ValueOne"] = &customTypedInt{1}
 	env["ValueTwo"] = &customTypedString{"test"}
 
-	_, err := expr.Compile("ValueOne + ValueTwo", expr.Env(env), Patcher)
+	_, err := expr.Compile("ValueOne + ValueTwo", expr.Env(env), ValueGetter)
 	require.Error(t, err)
 }
 
@@ -137,7 +137,7 @@ func Test_valueUntypedAddMismatch(t *testing.T) {
 	env["ValueOne"] = &customUntypedInt{1}
 	env["ValueTwo"] = &customUntypedString{"test"}
 
-	program, err := expr.Compile("ValueOne + ValueTwo", expr.Env(env), Patcher)
+	program, err := expr.Compile("ValueOne + ValueTwo", expr.Env(env), ValueGetter)
 	require.NoError(t, err)
 
 	_, err = vm.Run(program, env)
@@ -149,7 +149,7 @@ func Test_valueTypedArray(t *testing.T) {
 	env := make(map[string]any)
 	env["ValueOne"] = &customTypedArray{[]any{1, 2}}
 
-	program, err := expr.Compile("ValueOne[0] + ValueOne[1]", expr.Env(env), Patcher)
+	program, err := expr.Compile("ValueOne[0] + ValueOne[1]", expr.Env(env), ValueGetter)
 	require.NoError(t, err)
 
 	out, err := vm.Run(program, env)
@@ -162,7 +162,7 @@ func Test_valueTypedMap(t *testing.T) {
 	env := make(map[string]any)
 	env["ValueOne"] = &customTypedMap{map[string]any{"one": 1, "two": 2}}
 
-	program, err := expr.Compile("ValueOne.one + ValueOne.two", expr.Env(env), Patcher)
+	program, err := expr.Compile("ValueOne.one + ValueOne.two", expr.Env(env), ValueGetter)
 	require.NoError(t, err)
 
 	out, err := vm.Run(program, env)