Skip to content

Commit 79b4f98

Browse files
viankakrisnagaearon
authored andcommitted
move getDifferenceLabel inside printFileSizes
1 parent 03140f4 commit 79b4f98

File tree

3 files changed

+23
-22
lines changed

3 files changed

+23
-22
lines changed

packages/react-dev-utils/getDifferenceLabel.js

Lines changed: 0 additions & 19 deletions
This file was deleted.

packages/react-dev-utils/printFileSizes.js

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ var chalk = require('chalk');
44
var filesize = require('filesize');
55
var stripAnsi = require('strip-ansi');
66
var gzipSize = require('gzip-size').sync;
7-
var removeFileNameHash = require('./removeFileNameHash');
8-
var getDifferenceLabel = require('./getDifferenceLabel');
97
// Print a detailed summary of build files.
108
module.exports = function printFileSizes(appBuild, stats, previousSizeMap) {
119
var assets = stats
@@ -45,4 +43,27 @@ module.exports = function printFileSizes(appBuild, stats, previousSizeMap) {
4543
});
4644
};
4745

46+
function removeFileNameHash(appBuild, fileName) {
47+
return fileName
48+
.replace(appBuild, '')
49+
.replace(/\/?(.*)(\.\w+)(\.js|\.css)/, (match, p1, p2, p3) => p1 + p3);
50+
};
51+
52+
// Input: 1024, 2048
53+
// Output: "(+1 KB)"
54+
function getDifferenceLabel(currentSize, previousSize) {
55+
var FIFTY_KILOBYTES = 1024 * 50;
56+
var difference = currentSize - previousSize;
57+
var fileSize = !Number.isNaN(difference) ? filesize(difference) : 0;
58+
if (difference >= FIFTY_KILOBYTES) {
59+
return chalk.red('+' + fileSize);
60+
} else if (difference < FIFTY_KILOBYTES && difference > 0) {
61+
return chalk.yellow('+' + fileSize);
62+
} else if (difference < 0) {
63+
return chalk.green(fileSize);
64+
} else {
65+
return '';
66+
}
67+
};
68+
4869

packages/react-scripts/scripts/build.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ var checkRequiredFiles = require('react-dev-utils/checkRequiredFiles');
3131
var copyPublicFolder = require('react-dev-utils/copyPublicFolder');
3232
var printFileSizes = require('react-dev-utils/printFileSizes');
3333
var removeFileNameHash = require('react-dev-utils/removeFileNameHash');
34-
var getDifferenceLabel = require('react-dev-utils/getDifferenceLabel');
3534
var recursive = require('recursive-readdir');
3635
var stripAnsi = require('strip-ansi');
3736

0 commit comments

Comments
 (0)