Bump deps, treat warnings as failures, and fix linter problems

Author: Timer

package.json

@@ -13,10 +13,10 @@
   "devDependencies": {
     "babel-eslint": "^7.1.1",
     "eslint": "^3.15.0",
-    "eslint-config-react-app": "0.5.1",
+    "eslint-config-react-app": "^0.5.1",
     "eslint-plugin-flowtype": "^2.30.0",
     "eslint-plugin-import": "^2.2.0",
-    "eslint-plugin-jsx-a11y": "2.2.3",
+    "eslint-plugin-jsx-a11y": "^2.2.3",
     "eslint-plugin-react": "^6.9.0",
     "lerna": "^2.0.0-beta.37",
     "lerna-changelog": "^0.2.3"

packages/babel-preset-react-app/index.js

@@ -6,6 +6,8 @@
  * LICENSE file in the root directory of this source tree. An additional grant
  * of patent rights can be found in the PATENTS file in the same directory.
  */
+
+// eslint-disable-next-line
 'use strict';
 
 var path = require('path');

packages/create-react-app/index.js

@@ -36,6 +36,7 @@
 //   /!\ DO NOT MODIFY THIS FILE /!\
 // ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
+// eslint-disable-next-line
 'use strict';
 
 var chalk = require('chalk');

packages/react-dev-utils/InterpolateHtmlPlugin.js

@@ -15,6 +15,7 @@
 // Learn more about creating plugins like this:
 // https://github.com/ampedandwired/html-webpack-plugin#events
 
+// eslint-disable-next-line
 'use strict';
 const escapeStringRegexp = require('escape-string-regexp');
 

packages/react-dev-utils/WatchMissingNodeModulesPlugin.js

@@ -11,6 +11,7 @@
 // We’re not sure why this isn't Webpack's default behavior.
 // See https://github.com/facebookincubator/create-react-app/issues/186.
 
+// eslint-disable-next-line
 'use strict';
 
 class WatchMissingNodeModulesPlugin {

packages/react-dev-utils/formatWebpackMessages.js

@@ -106,7 +106,7 @@ function formatMessage(message) {
   // from user code generated by WebPack. For more information see
   // https://github.com/facebookincubator/create-react-app/pull/1050
   message = message.replace(
-    /^\s*at\s((?!webpack:).)*:\d+:\d+[\s\)]*(\n|$)/gm, ''
+    /^\s*at\s((?!webpack:).)*:\d+:\d+[\s)]*(\n|$)/gm, ''
   ); // at ... ...:x:y
 
   return message;

packages/react-scripts/bin/react-scripts.js

@@ -14,13 +14,13 @@ case 'test':
     {stdio: 'inherit'}
   );
   if (result.signal) {
-    if (result.signal == 'SIGKILL') {
+    if (result.signal === 'SIGKILL') {
       console.log(
         'The build failed because the process exited too early. ' +
         'This probably means the system ran out of memory or someone called ' +
         '`kill -9` on the process.'
       );
-    } else if (result.signal == 'SIGTERM') {
+    } else if (result.signal === 'SIGTERM') {
       console.log(
         'The build failed because the process exited too early. ' +
         'Someone might have called `kill` or `killall`, or the system could ' +

packages/react-scripts/config/webpack.config.prod.js

@@ -15,7 +15,6 @@ var HtmlWebpackPlugin = require('html-webpack-plugin');
 var ExtractTextPlugin = require('extract-text-webpack-plugin');
 var ManifestPlugin = require('webpack-manifest-plugin');
 var InterpolateHtmlPlugin = require('react-dev-utils/InterpolateHtmlPlugin');
-var url = require('url');
 var paths = require('./paths');
 var getClientEnvironment = require('./env');
 

packages/react-scripts/fixtures/kitchensink/integration/initDOM.js

@@ -15,7 +15,7 @@ if (process.env.E2E_FILE) {
   const markup = fs.readFileSync(file, 'utf8')
   getMarkup = () => markup
 
-  const pathPrefix = process.env.PUBLIC_URL.replace(/^https?:\/\/[^\/]+\/?/, '')
+  const pathPrefix = process.env.PUBLIC_URL.replace(/^https?:\/\/[^/]+\/?/, '')
 
   resourceLoader = (resource, callback) => callback(
     null,

tasks/e2e-simple.sh

@@ -83,7 +83,7 @@ then
 fi
 
 # Lint own code
-./node_modules/.bin/eslint --ignore-path .gitignore ./
+./node_modules/.bin/eslint --max-warnings 0 --ignore-path .gitignore ./
 
 # ******************************************************************************
 # First, test the create-react-app development environment.

tasks/replace-own-deps.js

@@ -7,6 +7,8 @@
  * LICENSE file in the root directory of this source tree. An additional grant
  * of patent rights can be found in the PATENTS file in the same directory.
  */
+
+// eslint-disable-next-line
 'use strict';
 
 // Replaces internal dependencies in package.json with local package paths.