Skip to content

Commit d9ed896

Browse files
author
Patrick Dillon
committed
Comment on stripping only version or tag from package name arg
1 parent 33f9731 commit d9ed896

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

packages/create-react-app/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,9 +152,10 @@ function getInstallPackage(version) {
152152

153153
// Extract package name from tarball url or path.
154154
function getPackageName(installPackage) {
155-
if (installPackage.indexOf('.tgz') > 0) {
155+
if (installPackage.indexOf('.tgz') > -1) {
156156
return installPackage.match(/^.+\/(.+)-.+\.tgz$/)[1];
157157
} else if (installPackage.indexOf('@') > 0) {
158+
// Do not match @scope/ when stripping off @version or @tag
158159
return installPackage.charAt(0) + installPackage.substr(1).split('@')[0];
159160
}
160161
return installPackage;

0 commit comments

Comments
 (0)