Use pre node@4 compatible path-exists
#685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fc3ab46.
SimenB
commented
Sep 19, 2016
| @@ -58,7 +58,7 @@ | |||
| "json-loader": "0.5.4", | |||
| "object-assign": "4.1.0", | |||
| "opn": "4.0.2", | |||
| "path-exists": "3.0.0", | |||
| "path-exists": "2.1.0", | |||
There was a problem hiding this comment.
Not sure if you want this as well?
There was a problem hiding this comment.
Yeah, I think it's fine to use the same old version here for consistency. The new version doesn't have any additional functionality.
ghost
added
the
fson
approved these changes
Sep 19, 2016
| @@ -58,7 +58,7 @@ | |||
| "json-loader": "0.5.4", | |||
| "object-assign": "4.1.0", | |||
| "opn": "4.0.2", | |||
| "path-exists": "3.0.0", | |||
| "path-exists": "2.1.0", | |||
There was a problem hiding this comment.
Yeah, I think it's fine to use the same old version here for consistency. The new version doesn't have any additional functionality.
feiqitian
pushed a commit
to feiqitian/create-react-app
that referenced
this pull request
Oct 25, 2016
* Revert "Add ES5 version of `path-exists` to CLI" This reverts commit fc3ab46. * Use pre node@4 compatible `path-exists` Ref facebook#617
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sindresorhus/path-exists#4 (comment)