Skip to content

Commit 0384e3c

Browse files
mdvaccafacebook-github-bot
authored andcommitted
Remove support for Android API < 23 in PermissionsModule (#39680)
Summary: Pull Request resolved: #39680 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class PermissionsModule changelog: [Android][Breaking] Remove support for Android API < 23 in PermissionsModule Reviewed By: NickGerleman Differential Revision: D48545517 fbshipit-source-id: 1ead079689aee5fd42d2b0bc530b7f69780938ff
1 parent 52ec1d8 commit 0384e3c

File tree

1 file changed

+1
-29
lines changed

1 file changed

+1
-29
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/permissions/PermissionsModule.java

Lines changed: 1 addition & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
import android.app.Activity;
1111
import android.content.Context;
1212
import android.content.pm.PackageManager;
13-
import android.os.Build;
14-
import android.os.Process;
1513
import android.util.SparseArray;
1614
import com.facebook.common.logging.FLog;
1715
import com.facebook.fbreact.specs.NativePermissionsAndroidSpec;
@@ -49,12 +47,6 @@ public PermissionsModule(ReactApplicationContext reactContext) {
4947
@Override
5048
public void checkPermission(final String permission, final Promise promise) {
5149
Context context = getReactApplicationContext().getBaseContext();
52-
if (Build.VERSION.SDK_INT < Build.VERSION_CODES.M) {
53-
promise.resolve(
54-
context.checkPermission(permission, Process.myPid(), Process.myUid())
55-
== PackageManager.PERMISSION_GRANTED);
56-
return;
57-
}
5850
promise.resolve(context.checkSelfPermission(permission) == PackageManager.PERMISSION_GRANTED);
5951
}
6052

@@ -68,10 +60,6 @@ public void checkPermission(final String permission, final Promise promise) {
6860
*/
6961
@Override
7062
public void shouldShowRequestPermissionRationale(final String permission, final Promise promise) {
71-
if (Build.VERSION.SDK_INT < Build.VERSION_CODES.M) {
72-
promise.resolve(false);
73-
return;
74-
}
7563
try {
7664
promise.resolve(
7765
getPermissionAwareActivity().shouldShowRequestPermissionRationale(permission));
@@ -89,14 +77,6 @@ public void shouldShowRequestPermissionRationale(final String permission, final
8977
@Override
9078
public void requestPermission(final String permission, final Promise promise) {
9179
Context context = getReactApplicationContext().getBaseContext();
92-
if (Build.VERSION.SDK_INT < Build.VERSION_CODES.M) {
93-
promise.resolve(
94-
context.checkPermission(permission, Process.myPid(), Process.myUid())
95-
== PackageManager.PERMISSION_GRANTED
96-
? GRANTED
97-
: DENIED);
98-
return;
99-
}
10080
if (context.checkSelfPermission(permission) == PackageManager.PERMISSION_GRANTED) {
10181
promise.resolve(GRANTED);
10282
return;
@@ -142,15 +122,7 @@ public void requestMultiplePermissions(final ReadableArray permissions, final Pr
142122
for (int i = 0; i < permissions.size(); i++) {
143123
String perm = permissions.getString(i);
144124

145-
if (Build.VERSION.SDK_INT < Build.VERSION_CODES.M) {
146-
grantedPermissions.putString(
147-
perm,
148-
context.checkPermission(perm, Process.myPid(), Process.myUid())
149-
== PackageManager.PERMISSION_GRANTED
150-
? GRANTED
151-
: DENIED);
152-
checkedPermissionsCount++;
153-
} else if (context.checkSelfPermission(perm) == PackageManager.PERMISSION_GRANTED) {
125+
if (context.checkSelfPermission(perm) == PackageManager.PERMISSION_GRANTED) {
154126
grantedPermissions.putString(perm, GRANTED);
155127
checkedPermissionsCount++;
156128
} else {

0 commit comments

Comments
 (0)