Skip to content

Commit 1e659dc

Browse files
cipolleschiblakef
authored andcommitted
Fix Typo and skip generation of app-specific component registration (#47547)
Summary: Pull Request resolved: #47547 In [#47176](#47176) we disabled the generation of the component registration for app specific components as it was creating a circular dependency between the app and React Native. However, we made a couple of typos that make it not work as expected and users picked up those typos soon. This change fixes them for good. ## Changelog [iOS][Fixed] - Properly stop generating component registration for components defined in app. Reviewed By: blakef Differential Revision: D65750433 fbshipit-source-id: 1a879c5be014905558b9fd05e6f16ac36b784ed6
1 parent 9f65442 commit 1e659dc

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

packages/react-native/scripts/codegen/generate-artifacts-executor.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -492,7 +492,7 @@ function rootCodegenTargetNeedsThirdPartyComponentProvider(pkgJson, platform) {
492492
function dependencyNeedsThirdPartyComponentProvider(
493493
schemaInfo,
494494
platform,
495-
appCondegenConfigSpec,
495+
appCodegenConfigSpec,
496496
) {
497497
// Filter the react native core library out.
498498
// In the future, core library and third party library should
@@ -503,7 +503,7 @@ function dependencyNeedsThirdPartyComponentProvider(
503503
// the symbols defined in the app.
504504
return (
505505
!isReactNativeCoreLibrary(schemaInfo.library.config.name, platform) &&
506-
schemaInfo.library.config.name !== appCondegenConfigSpec
506+
schemaInfo.library.config.name !== appCodegenConfigSpec
507507
);
508508
}
509509

@@ -719,7 +719,7 @@ function execute(projectRoot, targetPlatform, baseOutputPath) {
719719
dependencyNeedsThirdPartyComponentProvider(
720720
schemaInfo,
721721
platform,
722-
pkgJson.codegenConfig?.appCondegenConfigSpec,
722+
pkgJson.codegenConfig?.name,
723723
),
724724
);
725725
const schemas = filteredSchemas.map(schemaInfo => schemaInfo.schema);

0 commit comments

Comments
 (0)