Remove deprecation of onCatalystInstanceDestroy (#40777)

mdvacca · facebook-github-bot · commit b13ea1786f9e · 2023-10-10T16:16:56.000-07:00
Summary: Pull Request resolved: #40777 In this diff I'm removing the deprecation of NativeModule.onCatalystInstanceDestroy() method, changing it to DeprecatedInNewArchitecture changelog: [Android][Breaking] Mark NativeModule.onCatalystInstanceDestroy() method as deprecated in new architecture Reviewed By: christophpurrer Differential Revision: D50141027 fbshipit-source-id: a4c4911bdadc27f981f3af0522317e6dd08d9344
diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/NativeModule.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/NativeModule.java
@@ -52,7 +52,7 @@ interface NativeMethod {
    *
    * @deprecated use {@link #invalidate()} instead.
    */
-  @Deprecated(since = "Use invalidate method instead", forRemoval = true)
+  @DeprecatedInNewArchitecture(message = "Use invalidate method instead")
   void onCatalystInstanceDestroy();
 
   /** Allow NativeModule to clean up. Called before React Native instance is destroyed. */

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ interface NativeMethod {`
`52`	`52`	`*`
`53`	`53`	`* @deprecated use {@link #invalidate()} instead.`
`54`	`54`	`*/`
`55`		`- @Deprecated(since = "Use invalidate method instead", forRemoval = true)`
	`55`	`+ @DeprecatedInNewArchitecture(message = "Use invalidate method instead")`
`56`	`56`	`void onCatalystInstanceDestroy();`
`57`	`57`
`58`	`58`	`/** Allow NativeModule to clean up. Called before React Native instance is destroyed. */`