Skip to content

Commit bd3a3e3

Browse files
blakeffacebook-github-bot
blakef
authored and
facebook-github-bot
committed
Remove @react-native-community/cli direct dependencies (#45927)
Summary: Pull Request resolved: #45927 This was attempted earlier in the year, and was unsuccessful because HelloWorld had a hidden dependency on this. Changelog: [General][Breaking] Projects that intend to use the community CLI will now have to declare that dependency instead of transitively having the react-native package handle this. Reviewed By: GijsWeterings Differential Revision: D60898346 fbshipit-source-id: 1d62615f718e06caf684f48ecfaf610bf1f51f8e
1 parent e39b916 commit bd3a3e3

File tree

4 files changed

+81
-48
lines changed

4 files changed

+81
-48
lines changed

‎packages/react-native/package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,9 +110,6 @@
110110
},
111111
"dependencies": {
112112
"@jest/create-cache-key-function": "^29.6.3",
113-
"@react-native-community/cli": "14.0.0",
114-
"@react-native-community/cli-platform-android": "14.0.0",
115-
"@react-native-community/cli-platform-ios": "14.0.0",
116113
"@react-native/assets-registry": "0.76.0-main",
117114
"@react-native/codegen": "0.76.0-main",
118115
"@react-native/community-cli-plugin": "0.76.0-main",

‎packages/react-native/react-native.config.js

Lines changed: 26 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,29 @@ try {
4242
}
4343
}
4444

45-
const {
46-
bundleCommand,
47-
startCommand,
48-
} = require('@react-native/community-cli-plugin');
45+
const commands = [];
46+
47+
try {
48+
const {
49+
bundleCommand,
50+
startCommand,
51+
} = require('@react-native/community-cli-plugin');
52+
commands.push(bundleCommand, startCommand);
53+
} catch (e) {
54+
const known =
55+
e.code === 'MODULE_NOT_FOUND' &&
56+
e.message.includes('@react-native-community/cli-server-api');
57+
58+
if (!known) {
59+
throw e;
60+
}
61+
62+
if (verbose) {
63+
console.warn(
64+
'@react-native-community/cli-server-api not found, the react-native.config.js may be unusable.',
65+
);
66+
}
67+
}
4968

5069
const codegenCommand = {
5170
name: 'codegen',
@@ -74,8 +93,10 @@ const codegenCommand = {
7493
),
7594
};
7695

96+
commands.push(codegenCommand);
97+
7798
const config = {
78-
commands: [bundleCommand, startCommand, codegenCommand],
99+
commands,
79100
platforms: {},
80101
};
81102

‎packages/rn-tester/package.json

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@
2323
"clean-ios": "rm -rf build/generated/ios Pods Podfile.lock"
2424
},
2525
"dependencies": {
26+
"@react-native/oss-library-example": "0.76.0-main",
27+
"@react-native/popup-menu-android": "0.76.0-main",
2628
"flow-enums-runtime": "^0.0.6",
2729
"invariant": "^2.2.4",
28-
"nullthrows": "^1.1.1",
29-
"@react-native/oss-library-example": "0.76.0-main",
30-
"@react-native/popup-menu-android": "0.76.0-main"
30+
"nullthrows": "^1.1.1"
3131
},
3232
"peerDependencies": {
3333
"react": "19.0.0-rc-fb9a90fa48-20240614",
@@ -40,5 +40,10 @@
4040
"android": {
4141
"javaPackageName": "com.facebook.fbreact.specs"
4242
}
43+
},
44+
"devDependencies": {
45+
"@react-native-community/cli": "^14.0.0",
46+
"@react-native-community/cli-platform-android": "^14.0.0",
47+
"@react-native-community/cli-platform-ios": "^14.0.0"
4348
}
4449
}

‎yarn.lock

Lines changed: 47 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -2209,7 +2209,7 @@
22092209
wcwidth "^1.0.1"
22102210
yaml "^2.2.1"
22112211

2212-
"@react-native-community/[email protected]":
2212+
"@react-native-community/[email protected]", "@react-native-community/cli-platform-android@^14.0.0":
22132213
version "14.0.0"
22142214
resolved "https://registry.yarnpkg.com/@react-native-community/cli-platform-android/-/cli-platform-android-14.0.0.tgz#36f47999af9b386aaa8f8286923edd9a65101f28"
22152215
integrity sha512-nt7yVz3pGKQXnVa5MAk7zR+1n41kNKD3Hi2OgybH5tVShMBo7JQoL2ZVVH6/y/9wAwI/s7hXJgzf1OIP3sMq+Q==
@@ -2233,7 +2233,7 @@
22332233
fast-xml-parser "^4.2.4"
22342234
ora "^5.4.1"
22352235

2236-
"@react-native-community/[email protected]":
2236+
"@react-native-community/[email protected]", "@react-native-community/cli-platform-ios@^14.0.0":
22372237
version "14.0.0"
22382238
resolved "https://registry.yarnpkg.com/@react-native-community/cli-platform-ios/-/cli-platform-ios-14.0.0.tgz#7c7c393a13415bf61aaad82f1a3583c30afb110e"
22392239
integrity sha512-8kxGv7mZ5nGMtueQDq+ndu08f0ikf3Zsqm3Ix8FY5KCXpSgP14uZloO2GlOImq/zFESij+oMhCkZJGggpWpfAw==
@@ -2278,7 +2278,7 @@
22782278
dependencies:
22792279
joi "^17.2.1"
22802280

2281-
"@react-native-community/[email protected]":
2281+
"@react-native-community/cli@^14.0.0":
22822282
version "14.0.0"
22832283
resolved "https://registry.yarnpkg.com/@react-native-community/cli/-/cli-14.0.0.tgz#0c98d75ac55515d07972682c1053f46bfee93863"
22842284
integrity sha512-KwMKJB5jsDxqOhT8CGJ55BADDAYxlYDHv5R/ASQlEcdBEZxT0zZmnL0iiq2VqzETUy+Y/Nop+XDFgqyoQm0C2w==
@@ -3400,7 +3400,7 @@ builtins@^1.0.3:
34003400
[email protected]:
34013401
version "3.0.0"
34023402
resolved "https://registry.yarnpkg.com/bytes/-/bytes-3.0.0.tgz#d32815404d689699f85a4ea4fa8755dd13a96048"
3403-
integrity sha1-0ygVQE1olpn4Wk6k+odV3ROpYEg=
3403+
integrity sha512-pMhOfFDPiv9t5jjIXkHosWmkSyQbvsgEVNkz0ERHbuLh2T/7j4Mqqpz523Fe8MVY89KC6Sh/QfS2sM+SjgFDcw==
34043404

34053405
cacheable-lookup@^5.0.3:
34063406
version "5.0.4"
@@ -3699,9 +3699,9 @@ color-name@~1.1.4:
36993699
integrity sha512-dOy+3AuW3a2wNbZHIuMZpTcgjGuLU/uBL/ubcZF9OXbDo8ff4O8yVp5Bf0efS8uEoYo5q4Fx7dY9OgQGXgAsQA==
37003700

37013701
colorette@^1.0.7:
3702-
version "1.2.2"
3703-
resolved "https://registry.yarnpkg.com/colorette/-/colorette-1.2.2.tgz#cbcc79d5e99caea2dbf10eb3a26fd8b3e6acfa94"
3704-
integrity sha512-MKGMzyfeuutC/ZJ1cba9NqcNpfeqMUcYmyF1ZFY6/Cn7CNSAKx6a+s48sqLqyAiZuaP2TcqMhoo+dlwFnVxT9w==
3702+
version "1.4.0"
3703+
resolved "https://registry.yarnpkg.com/colorette/-/colorette-1.4.0.tgz#5190fbb87276259a86ad700bff2c6d6faa3fca40"
3704+
integrity sha512-Y2oEozpomLn7Q3HFP7dpww7AtMJplbM9lGZP6RDfHqmbeRjiwRg4n6VM6j4KLmRke85uWEI7JqF17f3pqdRA0g==
37053705

37063706
colorette@^2.0.20:
37073707
version "2.0.20"
@@ -3741,32 +3741,32 @@ commander@^4.0.1:
37413741
integrity sha512-NOKm8xhkzAjzFx8B2v5OAHT+u5pRQc2UCa2Vq9jYL/31o2wi9mxBA7LIFs3sV5VSC49z6pEhfbMULvShKj26WA==
37423742

37433743
commander@^9.4.1:
3744-
version "9.4.1"
3745-
resolved "https://registry.yarnpkg.com/commander/-/commander-9.4.1.tgz#d1dd8f2ce6faf93147295c0df13c7c21141cfbdd"
3746-
integrity sha512-5EEkTNyHNGFPD2H+c/dXXfQZYa/scCKasxWcXJaWnNJ99pnQN9Vnmqow+p+PlFPE63Q6mThaZws1T+HxfpgtPw==
3744+
version "9.5.0"
3745+
resolved "https://registry.yarnpkg.com/commander/-/commander-9.5.0.tgz#bc08d1eb5cedf7ccb797a96199d41c7bc3e60d30"
3746+
integrity sha512-KRs7WVDKg86PWiuAqhDrAQnTXZKraVcCc6vFdL14qrZ/DcWwuRo7VoiYXalXO7S5GKpqYiVEwCbgFDfxNHKJBQ==
37473747

37483748
commondir@^1.0.1:
37493749
version "1.0.1"
37503750
resolved "https://registry.yarnpkg.com/commondir/-/commondir-1.0.1.tgz#ddd800da0c66127393cca5950ea968a3aaf1253b"
37513751
integrity sha1-3dgA2gxmEnOTzKWVDqloo6rxJTs=
37523752

3753-
compressible@~2.0.14:
3754-
version "2.0.15"
3755-
resolved "https://registry.yarnpkg.com/compressible/-/compressible-2.0.15.tgz#857a9ab0a7e5a07d8d837ed43fe2defff64fe212"
3756-
integrity sha512-4aE67DL33dSW9gw4CI2H/yTxqHLNcxp0yS6jB+4h+wr3e43+1z7vm0HU9qXOH8j+qjKuL8+UtkOxYQSMq60Ylw==
3753+
compressible@~2.0.16:
3754+
version "2.0.18"
3755+
resolved "https://registry.yarnpkg.com/compressible/-/compressible-2.0.18.tgz#af53cca6b070d4c3c0750fbd77286a6d7cc46fba"
3756+
integrity sha512-AF3r7P5dWxL8MxyITRMlORQNaOA2IkAFaTr4k7BUumjPtRpGDTZpl0Pb1XCO6JeDCBdp126Cgs9sMxqSjgYyRg==
37573757
dependencies:
3758-
mime-db ">= 1.36.0 < 2"
3758+
mime-db ">= 1.43.0 < 2"
37593759

37603760
compression@^1.7.1:
3761-
version "1.7.3"
3762-
resolved "https://registry.yarnpkg.com/compression/-/compression-1.7.3.tgz#27e0e176aaf260f7f2c2813c3e440adb9f1993db"
3763-
integrity sha512-HSjyBG5N1Nnz7tF2+O7A9XUhyjru71/fwgNb7oIsEVHR0WShfs2tIS/EySLgiTe98aOK18YDlMXpzjCXY/n9mg==
3761+
version "1.7.4"
3762+
resolved "https://registry.yarnpkg.com/compression/-/compression-1.7.4.tgz#95523eff170ca57c29a0ca41e6fe131f41e5bb8f"
3763+
integrity sha512-jaSIDzP9pZVS4ZfQ+TzvtiWhdpFhE2RDHz8QJkpX9SIpLq88VueF5jJw6t+6CUQcAoA6t+x89MLrWAqpfDE8iQ==
37643764
dependencies:
37653765
accepts "~1.3.5"
37663766
bytes "3.0.0"
3767-
compressible "~2.0.14"
3767+
compressible "~2.0.16"
37683768
debug "2.6.9"
3769-
on-headers "~1.0.1"
3769+
on-headers "~1.0.2"
37703770
safe-buffer "5.1.2"
37713771
vary "~1.1.2"
37723772

@@ -3934,9 +3934,9 @@ data-uri-to-buffer@^6.0.1:
39343934
integrity sha512-MZd3VlchQkp8rdend6vrx7MmVDJzSNTBvghvKjirLkD+WTChA3KUf0jkE68Q4UyctNqI11zZO9/x2Yx+ub5Cvg==
39353935

39363936
dayjs@^1.8.15:
3937-
version "1.8.15"
3938-
resolved "https://registry.yarnpkg.com/dayjs/-/dayjs-1.8.15.tgz#7121bc04e6a7f2621ed6db566be4a8aaf8c3913e"
3939-
integrity sha512-HYHCI1nohG52B45vCQg8Re3hNDZbMroWPkhz50yaX7Lu0ATyjGsTdoYZBpjED9ar6chqTx2dmSmM8A51mojnAg==
3937+
version "1.11.12"
3938+
resolved "https://registry.yarnpkg.com/dayjs/-/dayjs-1.11.12.tgz#5245226cc7f40a15bf52e0b99fd2a04669ccac1d"
3939+
integrity sha512-Rt2g+nTbLlDWZTwwrIXjy9MeiZmSDI375FvZs72ngxx8PDC6YXOeR3q5LAuPzjZQxhiWdRKac7RKV+YyQYfYIg==
39403940

39413941
[email protected], debug@^2.2.0, debug@^2.6.9:
39423942
version "2.6.9"
@@ -5035,11 +5035,16 @@ got@^11.1.4:
50355035
p-cancelable "^2.0.0"
50365036
responselike "^2.0.0"
50375037

5038-
graceful-fs@^4.1.11, graceful-fs@^4.1.2, graceful-fs@^4.1.3, graceful-fs@^4.1.6, graceful-fs@^4.2.0, graceful-fs@^4.2.4, graceful-fs@^4.2.9:
5038+
graceful-fs@^4.1.11, graceful-fs@^4.1.2, graceful-fs@^4.1.6, graceful-fs@^4.2.0, graceful-fs@^4.2.4, graceful-fs@^4.2.9:
50395039
version "4.2.10"
50405040
resolved "https://registry.yarnpkg.com/graceful-fs/-/graceful-fs-4.2.10.tgz#147d3a006da4ca3ce14728c7aefc287c367d7a6c"
50415041
integrity sha512-9ByhssR2fPVsNZj478qUUbKfmL0+t5BDVyjShtyZZLiK7ZDAArFFfopyOTj0M05wE2tJPisA4iTnnXl2YoPvOA==
50425042

5043+
graceful-fs@^4.1.3:
5044+
version "4.2.11"
5045+
resolved "https://registry.yarnpkg.com/graceful-fs/-/graceful-fs-4.2.11.tgz#4183e4e8bf08bb6e05bbb2f7d2e0c8f712ca40e3"
5046+
integrity sha512-RbJ5/jmFcNNCcDV5o9eTnBLJ/HszWV0P73bc+Ff4nS/rJj+YaS6IGyiOL0VoBYX+l1Wrl3k63h/KrH+nhJ0XvQ==
5047+
50435048
grapheme-splitter@^1.0.4:
50445049
version "1.0.4"
50455050
resolved "https://registry.yarnpkg.com/grapheme-splitter/-/grapheme-splitter-1.0.4.tgz#9cf3a665c6247479896834af35cf1dbb4400767e"
@@ -5461,7 +5466,7 @@ is-fullwidth-code-point@^1.0.0:
54615466
is-fullwidth-code-point@^2.0.0:
54625467
version "2.0.0"
54635468
resolved "https://registry.yarnpkg.com/is-fullwidth-code-point/-/is-fullwidth-code-point-2.0.0.tgz#a3b30a5c4f199183167aaab93beefae3ddfb654f"
5464-
integrity sha1-o7MKXE8ZkYMWeqq5O+764937ZU8=
5469+
integrity sha512-VHskAKYM8RfSFXwee5t5cbN5PZeq1Wrh6qd5bkyiXIf6UQcN6w/A0eXM9r6t8d+GYOh+o6ZhiEnb88LN/Y8m2w==
54655470

54665471
is-fullwidth-code-point@^3.0.0:
54675472
version "3.0.0"
@@ -6780,11 +6785,16 @@ micromatch@^4.0.4:
67806785
braces "^3.0.1"
67816786
picomatch "^2.2.3"
67826787

6783-
[email protected], "mime-db@>= 1.36.0 < 2":
6788+
[email protected]:
67846789
version "1.52.0"
67856790
resolved "https://registry.yarnpkg.com/mime-db/-/mime-db-1.52.0.tgz#bbabcdc02859f4987301c856e3387ce5ec43bf70"
67866791
integrity sha512-sPU4uV7dYlvtWJxwwxHD0PuihVNiE7TyAbQ5SWxDCB9mUYvOgroQOwYQQOKPJ8CIbE+1ETVlOoK1UC2nU3gYvg==
67876792

6793+
"mime-db@>= 1.43.0 < 2":
6794+
version "1.53.0"
6795+
resolved "https://registry.yarnpkg.com/mime-db/-/mime-db-1.53.0.tgz#3cb63cd820fc29896d9d4e8c32ab4fcd74ccb447"
6796+
integrity sha512-oHlN/w+3MQ3rba9rqFr6V/ypF10LSkdwUysQL7GkXoTgIWeV+tcXGA852TBxH+gsh8UWoyhR1hKcoMJTuWflpg==
6797+
67886798
mime-types@^2.1.12, mime-types@^2.1.27, mime-types@~2.1.19, mime-types@~2.1.34:
67896799
version "2.1.35"
67906800
resolved "https://registry.yarnpkg.com/mime-types/-/mime-types-2.1.35.tgz#381a871b62a734450660ae3deee44813f70d959a"
@@ -6904,9 +6914,9 @@ neo-async@^2.5.0:
69046914
integrity sha512-Yd3UES5mWCSqR+qNT93S3UoYUkqAZ9lLg8a7g9rimsWmYGK8cVToA4/sF3RrshdyV3sAGMXVUmpMYOw+dLpOuw==
69056915

69066916
nocache@^3.0.1:
6907-
version "3.0.3"
6908-
resolved "https://registry.yarnpkg.com/nocache/-/nocache-3.0.3.tgz#07a3f4094746d5211c298d1938dcb5c1e1e352ca"
6909-
integrity sha512-bd+lPsDTjbfAuKez+xp8xvp15SrQuOjzajRGqRpCAE06FPB1pJzV/QkyBgFD5KOktv/M/A8M0vY7yatnOUaM5Q==
6917+
version "3.0.4"
6918+
resolved "https://registry.yarnpkg.com/nocache/-/nocache-3.0.4.tgz#5b37a56ec6e09fc7d401dceaed2eab40c8bfdf79"
6919+
integrity sha512-WDD0bdg9mbq6F4mRxEYcPWwfA1vxd0mrvKOyxI7Xj/atfRHVeutzuWByG//jfm4uPzp0y4Kj051EORCBSQMycw==
69106920

69116921
node-abort-controller@^3.1.1:
69126922
version "3.1.1"
@@ -6953,9 +6963,9 @@ node-releases@^2.0.6:
69536963
integrity sha512-PiVXnNuFm5+iYkLBNeq5211hvO38y63T0i2KKh2KnUs3RpzJ+JtODFjkD8yjLwnDkTYF1eKXheUwdssR+NRZdg==
69546964

69556965
node-stream-zip@^1.9.1:
6956-
version "1.9.1"
6957-
resolved "https://registry.yarnpkg.com/node-stream-zip/-/node-stream-zip-1.9.1.tgz#66d210204da7c60e2d6d685eb21a11d016981fd0"
6958-
integrity sha512-7/Xs9gkuYF0WBimz5OrSc6UVKLDTxvBG2yLGtEK8PSx94d86o/6iQLvIe/140ATz35JDqHKWIxh3GcA3u5hB0w==
6966+
version "1.15.0"
6967+
resolved "https://registry.yarnpkg.com/node-stream-zip/-/node-stream-zip-1.15.0.tgz#158adb88ed8004c6c49a396b50a6a5de3bca33ea"
6968+
integrity sha512-LN4fydt9TqhZhThkZIVQnF9cwjU3qmUH9h78Mx/K7d3VvfRqqwthLwJEUOEL0QPZ0XQmNN7be5Ggit5+4dq3Bw==
69596969

69606970
"normalize-package-data@~1.0.1 || ^2.0.0 || ^3.0.0":
69616971
version "3.0.3"
@@ -7097,7 +7107,7 @@ on-finished@~2.3.0:
70977107
dependencies:
70987108
ee-first "1.1.1"
70997109

7100-
on-headers@~1.0.1:
7110+
on-headers@~1.0.2:
71017111
version "1.0.2"
71027112
resolved "https://registry.yarnpkg.com/on-headers/-/on-headers-1.0.2.tgz#772b0ae6aaa525c399e489adfad90c403eb3c28f"
71037113
integrity sha512-pZAE+FJLoyITytdqK0U5s+FIpjN0JP3OzFi/u8Rx+EV5/W+JTWGXG8xFzevE7AjBfDqHv/8vL8qQsIhHnqRkrA==
@@ -8704,7 +8714,7 @@ validate-npm-package-name@^3.0.0:
87048714
vary@~1.1.2:
87058715
version "1.1.2"
87068716
resolved "https://registry.yarnpkg.com/vary/-/vary-1.1.2.tgz#2299f02c6ded30d4a5961b0b9f74524a18f634fc"
8707-
integrity sha1-IpnwLG3tMNSllhsLn3RSShj2NPw=
8717+
integrity sha512-BNGbWLfd0eUPabhkXUVm0j8uuvREyTh5ovRa/dyow/BqAbZJyC+5fU+IzQOzmAKzYqYRAISoRhdQr3eIZ/PXqg==
87088718

87098719
[email protected]:
87108720
version "1.10.0"
@@ -8884,9 +8894,9 @@ yallist@^4.0.0:
88848894
integrity sha512-3wdGidZyq5PB084XLES5TpOSRA3wjXAlIWMhum2kRcv/41Sn2emQ0dycQW4uZXLejwKvg6EsvbdlVL+FYEct7A==
88858895

88868896
yaml@^2.2.1:
8887-
version "2.3.1"
8888-
resolved "https://registry.yarnpkg.com/yaml/-/yaml-2.3.1.tgz#02fe0975d23cd441242aa7204e09fc28ac2ac33b"
8889-
integrity sha512-2eHWfjaoXgTBC2jNM1LRef62VQa0umtvRiDSk6HSzW7RvS5YtkabJrwYLLEKWBc8a5U2PTSCs+dJjUTJdlHsWQ==
8897+
version "2.5.0"
8898+
resolved "https://registry.yarnpkg.com/yaml/-/yaml-2.5.0.tgz#c6165a721cf8000e91c36490a41d7be25176cf5d"
8899+
integrity sha512-2wWLbGbYDiSqqIKoPjar3MPgB94ErzCtrNE1FdqGuaO0pi2JGjmE8aW8TDZwzU7vuxcGRdL/4gPQwQ7hD5AMSw==
88908900

88918901
yaml@^2.4.1:
88928902
version "2.4.1"

0 commit comments

Comments
 (0)