Remove custom derivative for LearningPhaseDependent.forward(_:).

Work around issues with `@differentiable` + `@derivative` attributes with
different derivative generic signatures.

Related discussion: swiftlang/swift#28621 (comment)
https://bugs.swift.org/browse/TF-1037 tracks this issue.

Author: dan-zheng

swift/FastaiNotebook_07_batchnorm/Sources/FastaiNotebook_07_batchnorm/07_batchnorm.swift

@@ -26,30 +26,13 @@ public protocol LearningPhaseDependent: FALayer {
 }
 
 extension LearningPhaseDependent {
-    // This `@differentiable` attribute is necessary, to tell the compiler that this satisfies the FALayer
-    // protocol requirement, even though there is a `@derivative(of: forward)` method below.
-    // TODO: It seems nondeterministically necessary. Some subsequent notebooks import this successfully without it,
-    // some require it. Investigate.
-    @differentiable(vjp: gradForward)
+    @differentiable
     public func forward(_ input: Input) -> Output {
         switch Context.local.learningPhase {
         case .training:  return forwardTraining(input)
         case .inference: return forwardInference(input)
         }
     }
-
-    @usableFromInline
-    // @derivative(of: forward)
-    func gradForward(_ input: Input) ->
-        (value: Output, pullback: (Self.Output.TangentVector) ->
-            (Self.TangentVector, Self.Input.TangentVector)) {
-        switch Context.local.learningPhase {
-        case .training:
-            return valueWithPullback(at: input) { $0.forwardTraining ($1) }
-        case .inference:
-            return valueWithPullback(at: input) { $0.forwardInference($1) }
-        }
-    }
 }
 
 public protocol Norm: Layer where Input == Tensor<Scalar>, Output == Tensor<Scalar>{

swift/FastaiNotebook_08_data_block/Sources/FastaiNotebook_08_data_block/07_batchnorm.swift

@@ -24,29 +24,13 @@ public protocol LearningPhaseDependent: FALayer {
 }
 
 extension LearningPhaseDependent {
-    // This `@differentiable` attribute is necessary, to tell the compiler that this satisfies the FALayer
-    // protocol requirement, even though there is a `@differentiating(forward)` method below.
-    // TODO: It seems nondeterministically necessary. Some subsequent notebooks import this successfully without it,
-    // some require it. Investigate.
     @differentiable
     public func forward(_ input: Input) -> Output {
         switch Context.local.learningPhase {
         case .training:  return forwardTraining(input)
         case .inference: return forwardInference(input)
         }
     }
-
-    @differentiating(forward)
-    func gradForward(_ input: Input) ->
-        (value: Output, pullback: (Self.Output.TangentVector) ->
-            (Self.TangentVector, Self.Input.TangentVector)) {
-        switch Context.local.learningPhase {
-        case .training:
-            return valueWithPullback(at: input) { $0.forwardTraining ($1) }
-        case .inference:
-            return valueWithPullback(at: input) { $0.forwardInference($1) }
-        }
-    }
 }
 
 public protocol Norm: Layer where Input == Tensor<Scalar>, Output == Tensor<Scalar>{

swift/FastaiNotebook_08a_heterogeneous_dictionary/Sources/FastaiNotebook_08a_heterogeneous_dictionary/07_batchnorm.swift

@@ -24,29 +24,13 @@ public protocol LearningPhaseDependent: FALayer {
 }
 
 extension LearningPhaseDependent {
-    // This `@differentiable` attribute is necessary, to tell the compiler that this satisfies the FALayer
-    // protocol requirement, even though there is a `@differentiating(forward)` method below.
-    // TODO: It seems nondeterministically necessary. Some subsequent notebooks import this successfully without it,
-    // some require it. Investigate.
     @differentiable
     public func forward(_ input: Input) -> Output {
         switch Context.local.learningPhase {
         case .training:  return forwardTraining(input)
         case .inference: return forwardInference(input)
         }
     }
-
-    @differentiating(forward)
-    func gradForward(_ input: Input) ->
-        (value: Output, pullback: (Self.Output.TangentVector) ->
-            (Self.TangentVector, Self.Input.TangentVector)) {
-        switch Context.local.learningPhase {
-        case .training:
-            return valueWithPullback(at: input) { $0.forwardTraining ($1) }
-        case .inference:
-            return valueWithPullback(at: input) { $0.forwardInference($1) }
-        }
-    }
 }
 
 public protocol Norm: Layer where Input == Tensor<Scalar>, Output == Tensor<Scalar>{

swift/FastaiNotebook_08c_data_block_generic/Sources/FastaiNotebook_08c_data_block_generic/07_batchnorm.swift

@@ -24,29 +24,13 @@ public protocol LearningPhaseDependent: FALayer {
 }
 
 extension LearningPhaseDependent {
-    // This `@differentiable` attribute is necessary, to tell the compiler that this satisfies the FALayer
-    // protocol requirement, even though there is a `@differentiating(forward)` method below.
-    // TODO: It seems nondeterministically necessary. Some subsequent notebooks import this successfully without it,
-    // some require it. Investigate.
     @differentiable
     public func forward(_ input: Input) -> Output {
         switch Context.local.learningPhase {
         case .training:  return forwardTraining(input)
         case .inference: return forwardInference(input)
         }
     }
-
-    @differentiating(forward)
-    func gradForward(_ input: Input) ->
-        (value: Output, pullback: (Self.Output.TangentVector) ->
-            (Self.TangentVector, Self.Input.TangentVector)) {
-        switch Context.local.learningPhase {
-        case .training:
-            return valueWithPullback(at: input) { $0.forwardTraining ($1) }
-        case .inference:
-            return valueWithPullback(at: input) { $0.forwardInference($1) }
-        }
-    }
 }
 
 public protocol Norm: Layer where Input == Tensor<Scalar>, Output == Tensor<Scalar>{

swift/FastaiNotebook_09_optimizer/Sources/FastaiNotebook_09_optimizer/07_batchnorm.swift

@@ -24,29 +24,13 @@ public protocol LearningPhaseDependent: FALayer {
 }
 
 extension LearningPhaseDependent {
-    // This `@differentiable` attribute is necessary, to tell the compiler that this satisfies the FALayer
-    // protocol requirement, even though there is a `@differentiating(forward)` method below.
-    // TODO: It seems nondeterministically necessary. Some subsequent notebooks import this successfully without it,
-    // some require it. Investigate.
     @differentiable
     public func forward(_ input: Input) -> Output {
         switch Context.local.learningPhase {
         case .training:  return forwardTraining(input)
         case .inference: return forwardInference(input)
         }
     }
-
-    @differentiating(forward)
-    func gradForward(_ input: Input) ->
-        (value: Output, pullback: (Self.Output.TangentVector) ->
-            (Self.TangentVector, Self.Input.TangentVector)) {
-        switch Context.local.learningPhase {
-        case .training:
-            return valueWithPullback(at: input) { $0.forwardTraining ($1) }
-        case .inference:
-            return valueWithPullback(at: input) { $0.forwardInference($1) }
-        }
-    }
 }
 
 public protocol Norm: Layer where Input == Tensor<Scalar>, Output == Tensor<Scalar>{

swift/FastaiNotebook_10_mixup_ls/Sources/FastaiNotebook_10_mixup_ls/07_batchnorm.swift

@@ -24,29 +24,13 @@ public protocol LearningPhaseDependent: FALayer {
 }
 
 extension LearningPhaseDependent {
-    // This `@differentiable` attribute is necessary, to tell the compiler that this satisfies the FALayer
-    // protocol requirement, even though there is a `@differentiating(forward)` method below.
-    // TODO: It seems nondeterministically necessary. Some subsequent notebooks import this successfully without it,
-    // some require it. Investigate.
     @differentiable
     public func forward(_ input: Input) -> Output {
         switch Context.local.learningPhase {
         case .training:  return forwardTraining(input)
         case .inference: return forwardInference(input)
         }
     }
-
-    @differentiating(forward)
-    func gradForward(_ input: Input) ->
-        (value: Output, pullback: (Self.Output.TangentVector) ->
-            (Self.TangentVector, Self.Input.TangentVector)) {
-        switch Context.local.learningPhase {
-        case .training:
-            return valueWithPullback(at: input) { $0.forwardTraining ($1) }
-        case .inference:
-            return valueWithPullback(at: input) { $0.forwardInference($1) }
-        }
-    }
 }
 
 public protocol Norm: Layer where Input == Tensor<Scalar>, Output == Tensor<Scalar>{

swift/FastaiNotebook_11_imagenette/Sources/FastaiNotebook_11_imagenette/07_batchnorm.swift

@@ -24,29 +24,13 @@ public protocol LearningPhaseDependent: FALayer {
 }
 
 extension LearningPhaseDependent {
-    // This `@differentiable` attribute is necessary, to tell the compiler that this satisfies the FALayer
-    // protocol requirement, even though there is a `@differentiating(forward)` method below.
-    // TODO: It seems nondeterministically necessary. Some subsequent notebooks import this successfully without it,
-    // some require it. Investigate.
     @differentiable
     public func forward(_ input: Input) -> Output {
         switch Context.local.learningPhase {
         case .training:  return forwardTraining(input)
         case .inference: return forwardInference(input)
         }
     }
-
-    @differentiating(forward)
-    func gradForward(_ input: Input) ->
-        (value: Output, pullback: (Self.Output.TangentVector) ->
-            (Self.TangentVector, Self.Input.TangentVector)) {
-        switch Context.local.learningPhase {
-        case .training:
-            return valueWithPullback(at: input) { $0.forwardTraining ($1) }
-        case .inference:
-            return valueWithPullback(at: input) { $0.forwardInference($1) }
-        }
-    }
 }
 
 public protocol Norm: Layer where Input == Tensor<Scalar>, Output == Tensor<Scalar>{

swift/Runnable11/Sources/Runnable11/07_batchnorm.swift

@@ -22,28 +22,13 @@ public protocol LearningPhaseDependent: FALayer {
 }
 
 public extension LearningPhaseDependent {
-    // This `@differentiable` attribute is necessary, to tell the compiler that this satisfies the FALayer
-    // protocol requirement, even though there is a `@differentiating(forward)` method below.
-    // TODO: It seems nondeterministically necessary. Some subsequent notebooks import this successfully without it,
-    // some require it. Investigate.
-    @differentiable(vjp: gradForward)
+    @differentiable
     public func forward(_ input: Input) -> Output {
         switch Context.local.learningPhase {
         case .training: return forwardTraining(to: input)
         case .inference: return forwardInference(to: input)
         }
     }
-
-    func gradForward(_ input: Input) ->
-        (Output, (Self.Output.TangentVector) ->
-            (Self.TangentVector, Self.Input.TangentVector)) {
-        switch Context.local.learningPhase {
-        case .training:
-            return valueWithPullback(at: input) { $0.forwardTraining(to: $1) }
-        case .inference:
-            return valueWithPullback(at: input) { $0.forwardInference(to: $1) }
-        }
-    }
 }
 
 public protocol Norm: Layer where Input == Tensor<Scalar>, Output == Tensor<Scalar>{