Merge pull request #624 from puilp0502/facebook-without-email

samtstern · web-flow · commit 1b1cdb5f9a1c · 2017-03-15T17:30:47.000-04:00
Support Facebook Login without email
diff --git a/auth/src/main/java/com/firebase/ui/auth/provider/FacebookProvider.java b/auth/src/main/java/com/firebase/ui/auth/provider/FacebookProvider.java
@@ -146,8 +146,8 @@ public void onCompleted(JSONObject object, GraphResponse response) {
                                 String email = object.getString("email");
                                 onSuccess(email, loginResult);
                             } catch (JSONException e) {
-                                Log.e(TAG, "JSON Exception reading from Facebook GraphRequest", e);
-                                onFailure(new Bundle());
+                                Log.e(TAG, "Failure retrieving Facebook email", e);
+                                onSuccess(null, loginResult);
                             }
                         }
                     }

Original file line number	Diff line number	Diff line change
`@@ -146,8 +146,8 @@ public void onCompleted(JSONObject object, GraphResponse response) {`
`146`	`146`	`String email = object.getString("email");`
`147`	`147`	`onSuccess(email, loginResult);`
`148`	`148`	`} catch (JSONException e) {`
`149`		`- Log.e(TAG, "JSON Exception reading from Facebook GraphRequest", e);`
`150`		`- onFailure(new Bundle());`
	`149`	`+ Log.e(TAG, "Failure retrieving Facebook email", e);`
	`150`	`+ onSuccess(null, loginResult);`
`151`	`151`	`}`
`152`	`152`	`}`
`153`	`153`	`}`