Skip to content

Commit 21d5d44

Browse files
committed
Renamed original onChanged to onChildChanged, renamed new onReady to onDataChanged.
1 parent 71b81f6 commit 21d5d44

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

database/src/main/java/com/firebase/ui/database/FirebaseArray.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,12 @@ class FirebaseArray implements ChildEventListener, ValueEventListener {
3030
public interface OnChangedListener {
3131
enum EventType {ADDED, CHANGED, REMOVED, MOVED}
3232

33-
void onChanged(EventType type, int index, int oldIndex);
33+
void onChildChanged(EventType type, int index, int oldIndex);
34+
35+
void onDataChanged();
3436

3537
void onCancelled(DatabaseError databaseError);
3638

37-
void onReady();
3839
}
3940

4041
private Query mQuery;
@@ -107,7 +108,7 @@ public void onChildMoved(DataSnapshot snapshot, String previousChildKey) {
107108

108109
@Override
109110
public void onDataChange(DataSnapshot dataSnapshot) {
110-
mListener.onReady();
111+
mListener.onDataChanged();
111112
}
112113

113114
@Override
@@ -125,7 +126,7 @@ protected void notifyChangedListeners(OnChangedListener.EventType type, int inde
125126

126127
protected void notifyChangedListeners(OnChangedListener.EventType type, int index, int oldIndex) {
127128
if (mListener != null) {
128-
mListener.onChanged(type, index, oldIndex);
129+
mListener.onChildChanged(type, index, oldIndex);
129130
}
130131
}
131132

database/src/main/java/com/firebase/ui/database/FirebaseListAdapter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public abstract class FirebaseListAdapter<T> extends BaseAdapter {
6767

6868
mSnapshots.setOnChangedListener(new FirebaseArray.OnChangedListener() {
6969
@Override
70-
public void onChanged(EventType type, int index, int oldIndex) {
70+
public void onChildChanged(EventType type, int index, int oldIndex) {
7171
notifyDataSetChanged();
7272
}
7373

@@ -77,7 +77,7 @@ public void onCancelled(DatabaseError databaseError) {
7777
}
7878

7979
@Override
80-
public void onReady() {
80+
public void onDataChanged() {
8181
FirebaseListAdapter.this.onDataChanged();
8282
}
8383
});

database/src/main/java/com/firebase/ui/database/FirebaseRecyclerAdapter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public abstract class FirebaseRecyclerAdapter<T, VH extends RecyclerView.ViewHol
8787

8888
mSnapshots.setOnChangedListener(new FirebaseArray.OnChangedListener() {
8989
@Override
90-
public void onChanged(EventType type, int index, int oldIndex) {
90+
public void onChildChanged(EventType type, int index, int oldIndex) {
9191
switch (type) {
9292
case ADDED:
9393
notifyItemInserted(index);
@@ -112,7 +112,7 @@ public void onCancelled(DatabaseError databaseError) {
112112
}
113113

114114
@Override
115-
public void onReady() {
115+
public void onDataChanged() {
116116
FirebaseRecyclerAdapter.this.onDataChanged();
117117
}
118118
});

0 commit comments

Comments
 (0)