Fix more check failures

Change-Id: I0b884bdbe5e62713dc3a4edca8539cace74f3f18

Author: samtstern

auth/build.gradle

@@ -56,6 +56,7 @@ dependencies {
     testCompile 'org.robolectric:robolectric:3.2.2'
     // See https://github.com/robolectric/robolectric/issues/1932#issuecomment-219796474
     testCompile 'org.khronos:opengl-api:gl1.1-android-2.1_r1'
+    testCompile 'com.facebook.android:facebook-android-sdk:4.23.0'
 }
 
 javadoc.exclude([

auth/src/main/java/com/firebase/ui/auth/ui/phone/CountryListSpinner.java

@@ -80,7 +80,7 @@ public void setSelectedForCountry(final Locale locale, String countryCode) {
         final String countryName = locale.getDisplayName();
         if (!TextUtils.isEmpty(countryName) && !TextUtils.isEmpty(countryCode)) {
             selectedCountryName = countryName;
-            setSpinnerText(Integer.valueOf(countryCode), locale);
+            setSpinnerText(Integer.parseInt(countryCode), locale);
         }
     }
 

auth/src/test/java/com/firebase/ui/auth/testhelpers/CustomCountDownTimerShadow.java

@@ -2,13 +2,9 @@
 
 import android.os.CountDownTimer;
 
-import com.firebase.ui.auth.ui.BaseHelper;
-import com.google.firebase.auth.PhoneAuthProvider;
-
 import org.mockito.Mock;
 import org.robolectric.annotation.Implementation;
 import org.robolectric.annotation.Implements;
-import org.robolectric.annotation.RealObject;
 
 @Implements(CountDownTimer.class)
 public class CustomCountDownTimerShadow {
@@ -22,6 +18,7 @@ public class CustomCountDownTimerShadow {
     public CustomCountDownTimerShadow() {
     }
 
+    @SuppressWarnings("checkstyle:methodname")
     public void __constructor__(long millisInFuture, long countDownInterval) {
         this.countDownInterval = countDownInterval;
         this.millisInFuture = millisInFuture;

auth/src/test/java/com/firebase/ui/auth/testhelpers/FacebookProviderShadow.java

@@ -14,9 +14,10 @@
 
 package com.firebase.ui.auth.testhelpers;
 
-import android.app.Activity;
+import android.support.annotation.StyleRes;
 
 import com.facebook.login.LoginResult;
+import com.firebase.ui.auth.AuthUI;
 import com.firebase.ui.auth.IdpResponse;
 import com.firebase.ui.auth.provider.FacebookProvider;
 import com.firebase.ui.auth.provider.IdpProvider.IdpCallback;
@@ -25,8 +26,6 @@
 import org.robolectric.annotation.Implementation;
 import org.robolectric.annotation.Implements;
 
-import java.util.List;
-
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
@@ -46,7 +45,7 @@ public FacebookProviderShadow() {
     }
 
     @SuppressWarnings("checkstyle:methodname")
-    public void __constructor__(Activity activity, List<String> scopes) {}
+    public void __constructor__(AuthUI.IdpConfig idpConfig, @StyleRes int theme) {}
 
     @Implementation
     public void setAuthenticationCallback(IdpCallback idpCallback) {

library/quality/checkstyle.xml

@@ -109,7 +109,7 @@ page at http://checkstyle.sourceforge.net/config.html -->
         <module name="MethodNameCheck">
             <!-- Validates identifiers for method names. -->
             <metadata name="altname" value="MethodName"/>
-            <property name="format" value="^(__)?+[a-z][a-zA-Z0-9]*(_[a-zA-Z0-9]+)*(__)?+$"/>
+            <property name="format" value="^[a-z][a-zA-Z0-9]*(_[a-zA-Z0-9]+)*$"/>
             <property name="severity" value="warning"/>
         </module>