Skip to content

Commit 3adb14a

Browse files
SUPERCILEXsamtstern
SUPERCILEX
authored and
samtstern
committed
Fix future lint errors (#704)
1 parent ee0a49a commit 3adb14a

File tree

4 files changed

+36
-68
lines changed

4 files changed

+36
-68
lines changed

‎auth/src/main/java/com/firebase/ui/auth/ui/email/RegisterEmailFragment.java

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -99,21 +99,20 @@ public View onCreateView(LayoutInflater inflater,
9999

100100
View v = inflater.inflate(R.layout.register_email_layout, container, false);
101101

102-
mPasswordFieldValidator = new PasswordFieldValidator(
103-
(TextInputLayout) v.findViewById(R.id.password_layout),
104-
getResources().getInteger(R.integer.min_password_length));
105-
mNameValidator = new RequiredFieldValidator(
106-
(TextInputLayout) v.findViewById(R.id.name_layout));
107-
mEmailFieldValidator = new EmailFieldValidator(
108-
(TextInputLayout) v.findViewById(R.id.email_layout));
109-
110102
mEmailEditText = (EditText) v.findViewById(R.id.email);
111103
mNameEditText = (EditText) v.findViewById(R.id.name);
112104
mPasswordEditText = (EditText) v.findViewById(R.id.password);
113105
mAgreementText = (TextView) v.findViewById(R.id.create_account_text);
114106
mEmailInput = (TextInputLayout) v.findViewById(R.id.email_layout);
115107
mPasswordInput = (TextInputLayout) v.findViewById(R.id.password_layout);
116108

109+
mPasswordFieldValidator = new PasswordFieldValidator(
110+
mPasswordInput,
111+
getResources().getInteger(R.integer.min_password_length));
112+
mNameValidator = new RequiredFieldValidator(
113+
(TextInputLayout) v.findViewById(R.id.name_layout));
114+
mEmailFieldValidator = new EmailFieldValidator(mEmailInput);
115+
117116
ImeHelper.setImeOnDoneListener(mPasswordEditText, this);
118117

119118
mEmailEditText.setOnFocusChangeListener(this);

‎auth/src/main/res/layout/welcome_back_idp_prompt_layout.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
android:id="@+id/welcome_back_idp_prompt"
1919
android:layout_width="match_parent"
2020
android:layout_height="wrap_content"
21+
android:textIsSelectable="false"
2122
tools:text="Good news! You've already used [email protected]. Sign in with Google to continue to SuperApp"/>
2223

2324
<Button

‎auth/src/main/res/values/styles.xml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0" encoding="utf-8"?>
2-
<resources>
2+
<resources xmlns:tools="http://schemas.android.com/tools">
33

44
<style name="FirebaseUI" parent="Theme.AppCompat.Light.DarkActionBar">
55
<item name="colorPrimary">@color/colorPrimary</item>
@@ -31,62 +31,62 @@
3131
<item name="android:fontFamily">sans-serif</item>
3232
</style>
3333

34-
<style name="FirebaseUI.Text.T01">
34+
<style name="FirebaseUI.Text.T01" tools:ignore="UnusedResources">
3535
<item name="android:textSize">112sp</item>
3636
</style>
3737

38-
<style name="FirebaseUI.Text.T02">
38+
<style name="FirebaseUI.Text.T02" tools:ignore="UnusedResources">
3939
<item name="android:textSize">64sp</item>
4040
</style>
4141

42-
<style name="FirebaseUI.Text.T03">
42+
<style name="FirebaseUI.Text.T03" tools:ignore="UnusedResources">
4343
<item name="android:textSize">48sp</item>
4444
</style>
4545

46-
<style name="FirebaseUI.Text.T04">
46+
<style name="FirebaseUI.Text.T04" tools:ignore="UnusedResources">
4747
<item name="android:textSize">36sp</item>
4848
<item name="android:lineSpacingExtra">12sp</item>
4949
</style>
5050

51-
<style name="FirebaseUI.Text.T05">
51+
<style name="FirebaseUI.Text.T05" tools:ignore="UnusedResources">
5252
<item name="android:textSize">24sp</item>
5353
<item name="android:lineSpacingExtra">8sp</item>
5454
</style>
5555

56-
<style name="FirebaseUI.Text.T06">
56+
<style name="FirebaseUI.Text.T06" tools:ignore="UnusedResources">
5757
<item name="android:textSize">18sp</item>
5858
<item name="android:lineSpacingExtra">6sp</item>
5959
</style>
6060

61-
<style name="FirebaseUI.Text.T07">
61+
<style name="FirebaseUI.Text.T07" tools:ignore="UnusedResources">
6262
<item name="android:textSize">20sp</item>
6363
<item name="android:lineSpacingExtra">4sp</item>
6464
<item name="android:textStyle">bold</item>
6565
</style>
6666

67-
<style name="FirebaseUI.Text.T08">
67+
<style name="FirebaseUI.Text.T08" tools:ignore="UnusedResources">
6868
<item name="android:textSize">16sp</item>
6969
<item name="android:lineSpacingExtra">8sp</item>
7070
</style>
7171

72-
<style name="FirebaseUI.Text.T09">
72+
<style name="FirebaseUI.Text.T09" tools:ignore="UnusedResources">
7373
<item name="android:textSize">16sp</item>
7474
<item name="android:lineSpacingExtra">4sp</item>
7575
<item name="android:textStyle">bold</item>
7676
</style>
7777

78-
<style name="FirebaseUI.Text.T11">
78+
<style name="FirebaseUI.Text.T11" tools:ignore="UnusedResources">
7979
<item name="android:textSize">14sp</item>
8080
<item name="android:lineSpacingExtra">6sp</item>
8181
<item name="android:textStyle">bold</item>
8282
</style>
8383

84-
<style name="FirebaseUI.Text.T12">
84+
<style name="FirebaseUI.Text.T12" tools:ignore="UnusedResources">
8585
<item name="android:textSize">12sp</item>
8686
<item name="android:lineSpacingExtra">4sp</item>
8787
</style>
8888

89-
<style name="FirebaseUI.Text.T13">
89+
<style name="FirebaseUI.Text.T13" tools:ignore="UnusedResources">
9090
<item name="android:textSize">10sp</item>
9191
</style>
9292

‎library/quality/lint-baseline.xml

Lines changed: 15 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -1,63 +1,31 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<issues format="4" by="lint 2.3.0-alpha2">
2+
<issues format="4" by="lint 2.4.0-alpha7">
33

44
<issue
55
id="RtlEnabled"
6-
severity="Error"
7-
message="The project references RTL attributes, but does not explicitly enable or disable RTL support with `android:supportsRtl` in the manifest"
8-
category="Internationalization:Bidirectional Text"
9-
priority="3"
10-
summary="Using RTL attributes without enabling RTL support"
11-
explanation="To enable right-to-left support, when running on API 17 and higher, you must set the `android:supportsRtl` attribute in the manifest `<application>` element. If you have started adding RTL attributes, but have not yet finished the migration, you can set the attribute to false to satisfy this lint check.">
12-
<location file="src/main/AndroidManifest.xml"/>
13-
</issue>
14-
15-
<!-- These ids are used in the AuthMethodPickerActivityTest.java tests -->
16-
<issue
17-
id="SelectableText"
18-
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
19-
errorLine1=" &lt;TextView"
20-
errorLine2=" ^">
6+
message="The project references RTL attributes, but does not explicitly enable or disable RTL support with `android:supportsRtl` in the manifest">
217
<location
22-
file="src/main/res/layout/register_email_layout.xml"
23-
line="79"
24-
column="9"/>
25-
</issue>
26-
27-
<issue
28-
id="SelectableText"
29-
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
30-
errorLine1=" &lt;TextView"
31-
errorLine2=" ^">
32-
<location
33-
file="src/main/res/layout/welcome_back_idp_prompt_layout.xml"
34-
line="16"
35-
column="5"/>
36-
</issue>
37-
38-
<issue
39-
id="SelectableText"
40-
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
41-
errorLine1=" &lt;TextView"
42-
errorLine2=" ^">
43-
<location
44-
file="src/main/res/layout/welcome_back_password_prompt_layout.xml"
45-
line="15"
46-
column="5"/>
8+
file="src/main/AndroidManifest.xml"/>
479
</issue>
4810

4911
<issue
5012
id="UnusedResources"
13+
severity="Error"
5114
message="The resource `R.string.google_crash_reporting_api_key` appears to be unused"
52-
errorLine1=" &lt;string name=&quot;google_crash_reporting_api_key&quot; translatable=&quot;false&quot;>AIzaSyAZYK9Jx9o0iR0XTVno_lX4a5GmhSt2sKA&lt;/string>"
53-
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
15+
category="Performance"
16+
priority="3"
17+
summary="Unused resources"
18+
explanation="Unused resources make applications larger and slow down builds."
19+
errorLine1=" &lt;string name=&quot;google_crash_reporting_api_key&quot; translatable=&quot;false&quot;>&lt;/string>"
20+
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"
21+
quickfix="studio">
5422
<location
55-
file="build/generated/res/google-services/release/values/values.xml"
56-
line="8"
23+
file="build/generated/res/google-services/debug/values/values.xml"
24+
line="7"
5725
column="13"/>
5826
<location
59-
file="build/generated/res/google-services/debug/values/values.xml"
60-
line="8"
27+
file="build/generated/res/google-services/release/values/values.xml"
28+
line="7"
6129
column="13"/>
6230
</issue>
6331

0 commit comments

Comments
 (0)