Skip to content

Commit 7f2ef5f

Browse files
SUPERCILEXsamtstern
authored andcommitted
Fix leaks (#429)
1 parent 8667f35 commit 7f2ef5f

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

auth/src/main/java/com/firebase/ui/auth/provider/FacebookProvider.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@ public class FacebookProvider implements IdpProvider, FacebookCallback<LoginResu
5555
private IdpCallback mCallbackObject;
5656

5757
public FacebookProvider(Context appContext, IdpConfig idpConfig) {
58+
appContext = appContext.getApplicationContext();
59+
5860
if (appContext.getResources().getIdentifier(
5961
"facebook_permissions", "array", appContext.getPackageName()) != 0) {
6062
Log.w(TAG, "DEVELOPER WARNING: You have defined R.array.facebook_permissions but that"

auth/src/main/java/com/firebase/ui/auth/provider/TwitterProvider.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
import android.content.Context;
55
import android.content.Intent;
66
import android.os.Bundle;
7-
87
import android.util.Log;
8+
99
import com.firebase.ui.auth.IdpResponse;
1010
import com.firebase.ui.auth.R;
1111
import com.google.firebase.auth.AuthCredential;
@@ -30,7 +30,7 @@ public TwitterProvider(Context appContext) {
3030
TwitterAuthConfig authConfig = new TwitterAuthConfig(
3131
appContext.getString(R.string.twitter_consumer_key),
3232
appContext.getString(R.string.twitter_consumer_secret));
33-
Fabric.with(appContext, new Twitter(authConfig));
33+
Fabric.with(appContext.getApplicationContext(), new Twitter(authConfig));
3434
mTwitterAuthClient = new TwitterAuthClient();
3535
}
3636

auth/src/main/java/com/firebase/ui/auth/util/signincontainer/IdpSignInContainer.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,10 +73,10 @@ public void onCreate(@Nullable Bundle savedInstanceState) {
7373
return;
7474
}
7575

76-
if (provider.equalsIgnoreCase(FacebookAuthProvider.PROVIDER_ID)) {
77-
mIdpProvider = new FacebookProvider(getContext(), providerConfig);
78-
} else if (provider.equalsIgnoreCase(GoogleAuthProvider.PROVIDER_ID)) {
76+
if (provider.equalsIgnoreCase(GoogleAuthProvider.PROVIDER_ID)) {
7977
mIdpProvider = new GoogleProvider(getActivity(), providerConfig, email);
78+
} else if (provider.equalsIgnoreCase(FacebookAuthProvider.PROVIDER_ID)) {
79+
mIdpProvider = new FacebookProvider(getContext(), providerConfig);
8080
} else if (provider.equalsIgnoreCase(TwitterAuthProvider.PROVIDER_ID)) {
8181
mIdpProvider = new TwitterProvider(getContext());
8282
}

0 commit comments

Comments
 (0)