Fix issues found by round of manual test (#383)

* Fix for unknown auth code

* Fix for Facebook login crash in chrome custom tab

* make callback manager static

* clean up for review

* add some more logging

* review feedback

Author: amandle

auth/src/main/java/com/firebase/ui/auth/provider/FacebookProvider.java

@@ -46,14 +46,12 @@ public class FacebookProvider implements IdpProvider, FacebookCallback<LoginResu
     private static final String TAG = "FacebookProvider";
     private static final String EMAIL = "email";
     private static final String PUBLIC_PROFILE = "public_profile";
+    private static final CallbackManager sCallbackManager = CallbackManager.Factory.create();
 
     private final List<String> mScopes;
-    private CallbackManager mCallbackManager;
     private IdpCallback mCallbackObject;
 
     public FacebookProvider(Context appContext, IdpConfig idpConfig) {
-        mCallbackManager = CallbackManager.Factory.create();
-
         if (appContext.getResources().getIdentifier(
                 "facebook_permissions", "array", appContext.getPackageName()) != 0) {
             Log.w(TAG, "DEVELOPER WARNING: You have defined R.array.facebook_permissions but that"
@@ -84,9 +82,8 @@ public String getProviderId() {
 
     @Override
     public void startLogin(Activity activity) {
-        mCallbackManager = CallbackManager.Factory.create();
         LoginManager loginManager = LoginManager.getInstance();
-        loginManager.registerCallback(mCallbackManager, this);
+        loginManager.registerCallback(sCallbackManager, this);
 
         List<String> permissionsList = new ArrayList<>(mScopes);
 
@@ -110,7 +107,7 @@ public void setAuthenticationCallback(IdpCallback callback) {
 
     @Override
     public void onActivityResult(int requestCode, int resultCode, Intent data) {
-        mCallbackManager.onActivityResult(requestCode, resultCode, data);
+        sCallbackManager.onActivityResult(requestCode, resultCode, data);
     }
 
     @Override

auth/src/main/java/com/firebase/ui/auth/ui/FlowParameters.java

@@ -89,10 +89,7 @@ public FlowParameters createFromParcel(Parcel in) {
             String termsOfServiceUrl = in.readString();
             int smartLockEnabledInt = in.readInt();
             boolean smartLockEnabled = (smartLockEnabledInt != 0);
-            List<String> additionalFacebookPermissions = new ArrayList<>();
-            in.readStringList(additionalFacebookPermissions);
-            List<String> additionalGooglePermissions = new ArrayList<>();
-            in.readStringList(additionalGooglePermissions);
+
             return new FlowParameters(
                     appName,
                     providerInfo,

auth/src/main/java/com/firebase/ui/auth/ui/email/EmailHintContainerActivity.java

@@ -20,6 +20,7 @@
 import android.content.IntentSender;
 import android.os.Bundle;
 
+import android.util.Log;
 import com.firebase.ui.auth.ui.AcquireEmailHelper;
 import com.firebase.ui.auth.ui.ActivityHelper;
 import com.firebase.ui.auth.ui.AppCompatBase;
@@ -29,6 +30,7 @@
 import com.google.android.gms.auth.api.credentials.Credential;
 
 public class EmailHintContainerActivity extends AppCompatBase {
+    private static final String TAG = "EmailHintContainer";
     private static final int RC_HINT = 13;
     private AcquireEmailHelper mAcquireEmailHelper;
 
@@ -45,7 +47,7 @@ protected void onCreate(Bundle savedInstanceState) {
                 startIntentSenderForResult(hintIntent.getIntentSender(), RC_HINT, null, 0, 0, 0);
                 return;
             } catch (IntentSender.SendIntentException e) {
-                e.printStackTrace();
+                Log.e(TAG, "Unable to start hint intent", e);
             }
         }
         finish(RESULT_CANCELED, new Intent());

auth/src/main/java/com/firebase/ui/auth/util/SmartLock.java

@@ -168,6 +168,7 @@ public void onResult(@NonNull Status status) {
                     finish();
                 }
             } else {
+                Log.w(TAG, status.getStatusMessage());
                 finish();
             }
         }

common/constants.gradle

@@ -1,5 +1,7 @@
 project.ext.firebase_version = '9.6.1'
-project.ext.support_library_version = '25.0.0'
+// use caution when updating support library version, v25.0.0 caused issues
+// with the Facebook SDK. (NoSuchMethodError startActivity)
+project.ext.support_library_version = '24.2.1'
 
 project.ext.submodules = ['database', 'auth', 'storage']
 project.ext.group = 'com.firebaseui'