Skip to content

Commit dfb8e52

Browse files
Aaron MandleGerrit Code Review
authored andcommitted
Merge "Don't set the theme on the Confirm Recovery Email screen since it is a dialog. Also removes a deleted entry from the manifest"
2 parents e9395fc + d9089b6 commit dfb8e52

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

auth/src/main/AndroidManifest.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,6 @@
2929
<activity android:theme="@style/FirebaseUI.Translucent"
3030
android:name="com.firebase.ui.auth.ui.idp.IDPSignInContainerActivity" >
3131
</activity>
32-
<activity android:theme="@style/FirebaseUI.Translucent"
33-
android:name="com.firebase.ui.auth.ui.credentials.CredentialsInitActivity" >
34-
</activity>
3532
<activity android:theme="@style/FirebaseUI.Translucent"
3633
android:name="com.firebase.ui.auth.ui.credentials.ChooseAccountActivity" >
3734
</activity>

auth/src/main/java/com/firebase/ui/auth/ui/email/ConfirmRecoverPasswordActivity.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,16 @@
2626
import com.firebase.ui.auth.ui.ExtraConstants;
2727
import com.firebase.ui.auth.ui.FlowParameters;
2828

29-
public class ConfirmRecoverPasswordActivity extends AppCompatBase implements View.OnClickListener {
29+
public class ConfirmRecoverPasswordActivity extends android.support.v7.app.AppCompatActivity
30+
implements View.OnClickListener {
31+
private ActivityHelper mActivityHelper;
3032

3133
@Override
3234
protected void onCreate(Bundle savedInstanceState) {
3335
super.onCreate(savedInstanceState);
36+
mActivityHelper = new ActivityHelper(this, getIntent());
37+
// intentionally do not configure the theme on this activity, it is a dialog
38+
3439
setContentView(R.layout.confirm_recovery_layout);
3540
setTitle(R.string.check_your_email);
3641
String email = getIntent().getStringExtra(ExtraConstants.EXTRA_EMAIL);
@@ -65,4 +70,8 @@ public static Intent createIntent(
6570
.putExtra(ExtraConstants.EXTRA_SUCCESS, success)
6671
.putExtra(ExtraConstants.EXTRA_EMAIL, email);
6772
}
73+
74+
private void finish(int resultCode, Intent intent) {
75+
mActivityHelper.finish(resultCode, intent);
76+
}
6877
}

0 commit comments

Comments
 (0)