Skip to content

Commit fd4de5a

Browse files
authored
Audit for missed instances of Twitter (#366)
Resolves issue #361
1 parent 9b98c12 commit fd4de5a

File tree

4 files changed

+12
-0
lines changed

4 files changed

+12
-0
lines changed

auth/src/main/java/com/firebase/ui/auth/ui/AuthCredentialHelper.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,11 @@
1919
import com.firebase.ui.auth.provider.FacebookProvider;
2020
import com.firebase.ui.auth.provider.GoogleProvider;
2121
import com.firebase.ui.auth.IdpResponse;
22+
import com.firebase.ui.auth.provider.TwitterProvider;
2223
import com.google.firebase.auth.AuthCredential;
2324
import com.google.firebase.auth.FacebookAuthProvider;
2425
import com.google.firebase.auth.GoogleAuthProvider;
26+
import com.google.firebase.auth.TwitterAuthProvider;
2527

2628
public class AuthCredentialHelper {
2729

@@ -32,6 +34,8 @@ public static AuthCredential getAuthCredential(IdpResponse idpResponse) {
3234
return GoogleProvider.createAuthCredential(idpResponse);
3335
case FacebookAuthProvider.PROVIDER_ID:
3436
return FacebookProvider.createAuthCredential(idpResponse);
37+
case TwitterAuthProvider.PROVIDER_ID:
38+
return TwitterProvider.createAuthCredential(idpResponse);
3539
default:
3640
return null;
3741
}

auth/src/main/java/com/firebase/ui/auth/ui/account_link/WelcomeBackIdpPrompt.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
import com.firebase.ui.auth.provider.IdpProvider;
3232
import com.firebase.ui.auth.provider.IdpProvider.IdpCallback;
3333
import com.firebase.ui.auth.IdpResponse;
34+
import com.firebase.ui.auth.provider.TwitterProvider;
3435
import com.firebase.ui.auth.ui.ActivityHelper;
3536
import com.firebase.ui.auth.ui.AppCompatBase;
3637
import com.firebase.ui.auth.ui.AuthCredentialHelper;
@@ -45,6 +46,7 @@
4546
import com.google.firebase.auth.FirebaseAuth;
4647
import com.google.firebase.auth.FirebaseUser;
4748
import com.google.firebase.auth.GoogleAuthProvider;
49+
import com.google.firebase.auth.TwitterAuthProvider;
4850

4951
public class WelcomeBackIdpPrompt extends AppCompatBase
5052
implements View.OnClickListener, IdpCallback {
@@ -73,6 +75,9 @@ protected void onCreate(Bundle savedInstanceState) {
7375
case FacebookAuthProvider.PROVIDER_ID:
7476
mIdpProvider = new FacebookProvider(this, idpConfig);
7577
break;
78+
case TwitterAuthProvider.PROVIDER_ID:
79+
mIdpProvider = new TwitterProvider(this);
80+
break;
7681
default:
7782
Log.w(TAG, "Unknown provider: " + mProviderId);
7883
finish(RESULT_CANCELED, getIntent());

auth/src/main/java/com/firebase/ui/auth/util/CredentialsApiHelper.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@ public CredentialRequest createCredentialRequest(List<IdpConfig> providers) {
5959
idps.add(IdentityProviders.GOOGLE);
6060
} else if (AuthUI.FACEBOOK_PROVIDER.equals(providerId)) {
6161
idps.add(IdentityProviders.FACEBOOK);
62+
} else if (AuthUI.TWITTER_PROVIDER.equals(providerId)) {
63+
idps.add(IdentityProviders.TWITTER);
6264
}
6365
}
6466

auth/src/test/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivityTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ public void testAllProvidersArePopulated() {
8282
List<String> providers = Arrays.asList(
8383
AuthUI.FACEBOOK_PROVIDER,
8484
AuthUI.GOOGLE_PROVIDER,
85+
AuthUI.TWITTER_PROVIDER,
8586
AuthUI.EMAIL_PROVIDER);
8687

8788
AuthMethodPickerActivity authMethodPickerActivity =

0 commit comments

Comments
 (0)