Skip to content

Update database access modifiers #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Nov 29, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ class FirebaseIndexArray extends FirebaseArray {
private static final String TAG = FirebaseIndexArray.class.getSimpleName();

private Query mQuery;
private OnChangedListener mListener;
private Map<Query, ValueEventListener> mRefs = new HashMap<>();
private List<DataSnapshot> mDataSnapshots = new ArrayList<>();
private OnChangedListener mListener;

FirebaseIndexArray(Query keyRef, Query dataRef) {
public FirebaseIndexArray(Query keyRef, Query dataRef) {
super(keyRef);
mQuery = dataRef;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,18 +51,18 @@
public abstract class FirebaseListAdapter<T> extends BaseAdapter {
private static final String TAG = FirebaseListAdapter.class.getSimpleName();

private FirebaseArray mSnapshots;
private final Class<T> mModelClass;
protected int mLayout;
protected Activity mActivity;
FirebaseArray mSnapshots;
protected int mLayout;

FirebaseListAdapter(Activity activity,
Class<T> modelClass,
@LayoutRes int modelLayout,
FirebaseArray snapshots) {
mActivity = activity;
mModelClass = modelClass;
mLayout = modelLayout;
mActivity = activity;
mSnapshots = snapshots;

mSnapshots.setOnChangedListener(new FirebaseArray.OnChangedListener() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,10 @@
public abstract class FirebaseRecyclerAdapter<T, VH extends RecyclerView.ViewHolder> extends RecyclerView.Adapter<VH> {
private static final String TAG = FirebaseRecyclerAdapter.class.getSimpleName();

private FirebaseArray mSnapshots;
private Class<T> mModelClass;
protected Class<VH> mViewHolderClass;
protected int mModelLayout;
Class<T> mModelClass;
Class<VH> mViewHolderClass;
FirebaseArray mSnapshots;

FirebaseRecyclerAdapter(Class<T> modelClass,
@LayoutRes int modelLayout,
Expand Down