Update gradle, update dependencies, fix Facebook theme, fix Facebook CCT #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
SUPERCILEX
commented
Dec 6, 2016
| @@ -15,6 +16,10 @@ | |||
| android:name="io.fabric.ApiKey" | |||
| android:value="@string/twitter_consumer_secret"/> | |||
|
|
|||
| <meta-data | |||
| android:name="com.facebook.sdk.ApplicationId" | |||
| android:value="@string/facebook_application_id"/> | |||
There was a problem hiding this comment.
This fixes the Chrome Custom Tabs issue where Facebook would use CCT completely randomly.
See step 8 in the official documentation: https://developers.facebook.com/docs/facebook-login/android
| FacebookSdk.sdkInitialize(appContext); | ||
| FacebookSdk.setApplicationId(applicationId); | ||
| FacebookSdk.setWebDialogTheme(theme); |
There was a problem hiding this comment.
This fixes the issue where the theme wasn't applied to the webview for some reason:
Old
New
|
@SUPERCILEX this is great! Thanks for solving that wacky CCT issue, I always assumed it was Facebook's fault somehow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.