Robolectic now supports api 25! #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Saveau <[email protected]>
|
Does this mean that Windows developers won't be able to run our tests? |
|
Ah, I forgot about that. Yeah, I don't think they'll be able to run the tests so is it okay if I just leave this PR up until robolectric fixes it? |
|
Yep SGTM, let's not merge it until all devs have a working solution for our
tests.
…On Thu, Jan 5, 2017 at 12:10 PM Alex Saveau ***@***.***> wrote:
Ah, I forgot about that. Yeah, I don't think they'll be able to run the
tests so is it okay if I just leave this PR up until robolectric fixes it?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#494 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIEw6ppuVtzL3dT2RmHUBOsgo4L0w5W7ks5rPU4YgaJpZM4LcDuC>
.
|
Signed-off-by: Alex Saveau <[email protected]>
|
The fix should be out tomorrow: robolectric/robolectric#2814 (comment). |
…ctic! # Conflicts: # auth/build.gradle
|
@samtstern The new version of robolectric came out: https://github.com/robolectric/robolectric/releases/tag/robolectric-3.2.1. |
|
@SUPERCILEX thanks for tracking that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade all our tests to target sdk 25.
Note: we're probably going to have to upgrade again soon because of a stopship (that wasn't stopped) on windows: robolectric/robolectric#2814.