Skip to content

Make KickoffActivity truly transparent #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2017

Conversation

samtstern
Copy link
Contributor

Change-Id: I590bf01d6af9583324ad2d9b85cb15100db8f85c
Change-Id: Id72fe795cbab250d832dec511af3e27a8cf351e5
@SUPERCILEX
Copy link
Collaborator

Woah!!! Thanks for this @samtstern, it looks amazing! I can't believe we never thought of the configureTheme thing!

@samtstern
Copy link
Contributor Author

Yeah the only downside here is the ProgressDialog in KickoffActivity is not themed with the user's custom theme but I think that's a worthwhile sacrifice given how much better it looks.

We didn't think of this because we were working on #357 at the time and had a lot on our minds 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants