Skip to content

Add info regarding tests, lint, and checkstyle #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2017
+4 −1
Merged

Add info regarding tests, lint, and checkstyle #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ae54c1
Add info regarding tests, lint, and checkstyle
SUPERCILEX Jan 10, 2017
5e899d5
Cleanup
SUPERCILEX Jan 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,10 @@ Feature parity (where it makes sense) is a strict requirement for feature develo
### Code reviews

All submissions, including submissions by project members, require review. We
use Github pull requests for this purpose. We adhere to the
use GitHub pull requests for this purpose. We adhere to the
[Google Java style guide](https://google.github.io/styleguide/javaguide.html).
In addition, style and lint checks are run on each Travis build to ensure quality. To run the full
suite of tests, checks, lint, etc, use `./gradlew check` (this will ensure the Travis build passes).

### The small print

Expand Down
1 change: 1 addition & 0 deletions PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
Hey there! So you want to contribute to FirebaseUI? Before you file this pull request, follow these steps:

* Read [the contribution guidelines](CONTRIBUTING.md).
* Run `./gradlew check` to ensure the Travis build passes.
* If this has been discussed in an issue, make sure to mention the issue number here. If not, go file an issue about this to make sure this is a desirable change.
* If this is a new feature please co-ordinate with someone on [FirebaseUI-iOS](https://github.com/firebase/firebaseui-ios) to make sure that we can implement this on both platforms and maintain feature parity.